Bug 56182

Summary: Move alignment macros from Vector.h to a separate file
Product: WebKit Reporter: Gabor Loki <loki>
Component: JavaScriptCoreAssignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Trivial CC: barraclough, buildbot, darin, kling, rhodovan.u-szeged, zherczeg
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 54456    
Attachments:
Description Flags
Move alignment macros from Vector.h to a separate file
none
Move alignment macros from Vector.h to a separate file
none
Move alignment macros from Vector.h to a separate file none

Description Gabor Loki 2011-03-11 05:41:45 PST
The alignment macros (from Vecror.h) deserve a separate file. In additional it is a requirement of bug 54456.
Comment 1 Gabor Loki 2011-03-11 05:42:44 PST
Created attachment 85465 [details]
Move alignment macros from Vector.h to a separate file
Comment 2 Build Bot 2011-03-11 06:33:18 PST
Attachment 85465 [details] did not build on win:
Build output: http://queues.webkit.org/results/8133276
Comment 3 Gabor Loki 2011-03-12 00:29:24 PST
Created attachment 85575 [details]
Move alignment macros from Vector.h to a separate file

Opps, I missed removing the original macros.
Comment 4 Gabor Loki 2011-03-12 01:42:43 PST
> Created an attachment (id=85575) [details]

Hmm. I don't know why svn-apply fails on ews. The same command works for me on git and svn repositories as well.

 $ SVN > Tools/Scripts/svn-apply patch
Parsed 8 diffs from patch file(s).
patching file Source/JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/JavaScriptCore/GNUmakefile.am
patching file Source/JavaScriptCore/JavaScriptCore.gypi
Hunk #1 succeeded at 127 (offset 1 line).
patching file Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTF.vcproj
patching file Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
patching file Source/JavaScriptCore/wtf/Alignment.h
A         Source/JavaScriptCore/wtf/Alignment.h
patching file Source/JavaScriptCore/wtf/CMakeLists.txt
patching file Source/JavaScriptCore/wtf/Vector.h

 $ GIT > Tools/Scripts/svn-apply patch
Parsed 8 diffs from patch file(s).
patching file Source/JavaScriptCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/JavaScriptCore/GNUmakefile.am
patching file Source/JavaScriptCore/JavaScriptCore.gypi
Hunk #1 succeeded at 127 (offset 1 line).
patching file Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTF.vcproj
patching file Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj
patching file Source/JavaScriptCore/wtf/Alignment.h
patching file Source/JavaScriptCore/wtf/CMakeLists.txt
patching file Source/JavaScriptCore/wtf/Vector.h
Comment 5 Gabor Loki 2011-03-12 02:30:09 PST
Created attachment 85582 [details]
Move alignment macros from Vector.h to a separate file

I have created the patch from svn. I hope svn-apply will succeed with it now.
Comment 6 Build Bot 2011-03-12 09:06:58 PST
Attachment 85582 [details] did not build on win:
Build output: http://queues.webkit.org/results/8148688
Comment 7 Andreas Kling 2011-03-12 19:50:08 PST
Looks a lot like bug 56000(?)
Comment 8 Darin Adler 2011-03-12 19:51:17 PST
]

*** This bug has been marked as a duplicate of bug 56000 ***