Bug 56182

Summary:

Move alignment macros from Vector.h to a separate file

Product:

WebKit

Reporter:

Gabor Loki <loki>

Component:

JavaScriptCore

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED DUPLICATE

Severity:

Trivial

CC:

barraclough, buildbot, darin, kling, rhodovan.u-szeged, zherczeg

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Bug Depends on:

Bug Blocks:

54456

Attachments:

Description	Flags
Move alignment macros from Vector.h to a separate file	none
Move alignment macros from Vector.h to a separate file	none
Move alignment macros from Vector.h to a separate file	none

Gabor Loki

Reported 2011-03-11 05:41:45 PST

The alignment macros (from Vecror.h) deserve a separate file. In additional it is a requirement of bug 54456.

Attachments
Move alignment macros from Vector.h to a separate file (8.82 KB, patch) 2011-03-11 05:42 PST, Gabor Loki	no flags	Details Formatted Diff Diff
Move alignment macros from Vector.h to a separate file (9.60 KB, patch) 2011-03-12 00:29 PST, Gabor Loki	no flags	Details Formatted Diff Diff
Move alignment macros from Vector.h to a separate file (8.85 KB, patch) 2011-03-12 02:30 PST, Gabor Loki	no flags	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Gabor Loki

Comment 1 2011-03-11 05:42:44 PST

Created attachment 85465 [details] Move alignment macros from Vector.h to a separate file

Build Bot

Comment 2 2011-03-11 06:33:18 PST

Attachment 85465 [details] did not build on win: Build output: http://queues.webkit.org/results/8133276

Gabor Loki

Comment 3 2011-03-12 00:29:24 PST

Created attachment 85575 [details] Move alignment macros from Vector.h to a separate file Opps, I missed removing the original macros.

Gabor Loki

Comment 4 2011-03-12 01:42:43 PST

> Created an attachment (id=85575) [details] Hmm. I don't know why svn-apply fails on ews. The same command works for me on git and svn repositories as well. $ SVN > Tools/Scripts/svn-apply patch Parsed 8 diffs from patch file(s). patching file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptCore/GNUmakefile.am patching file Source/JavaScriptCore/JavaScriptCore.gypi Hunk #1 succeeded at 127 (offset 1 line). patching file Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTF.vcproj patching file Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj patching file Source/JavaScriptCore/wtf/Alignment.h A Source/JavaScriptCore/wtf/Alignment.h patching file Source/JavaScriptCore/wtf/CMakeLists.txt patching file Source/JavaScriptCore/wtf/Vector.h $ GIT > Tools/Scripts/svn-apply patch Parsed 8 diffs from patch file(s). patching file Source/JavaScriptCore/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file Source/JavaScriptCore/GNUmakefile.am patching file Source/JavaScriptCore/JavaScriptCore.gypi Hunk #1 succeeded at 127 (offset 1 line). patching file Source/JavaScriptCore/JavaScriptCore.vcproj/WTF/WTF.vcproj patching file Source/JavaScriptCore/JavaScriptCore.xcodeproj/project.pbxproj patching file Source/JavaScriptCore/wtf/Alignment.h patching file Source/JavaScriptCore/wtf/CMakeLists.txt patching file Source/JavaScriptCore/wtf/Vector.h

Gabor Loki

Comment 5 2011-03-12 02:30:09 PST

Created attachment 85582 [details] Move alignment macros from Vector.h to a separate file I have created the patch from svn. I hope svn-apply will succeed with it now.

Build Bot

Comment 6 2011-03-12 09:06:58 PST

Attachment 85582 [details] did not build on win: Build output: http://queues.webkit.org/results/8148688

Andreas Kling

Comment 7 2011-03-12 19:50:08 PST

Looks a lot like bug 56000(?)

Darin Adler

Comment 8 2011-03-12 19:51:17 PST

] *** This bug has been marked as a duplicate of bug 56000 ***

Note You need to log in before you can comment on or make changes to this bug.