Bug 56159

Summary: provide API for creating WKImage from CGImageRef
Product: WebKit Reporter: Alice Liu <alice.barraclough>
Component: WebKit APIAssignee: Alice Liu <alice.barraclough>
Status: RESOLVED FIXED    
Severity: Normal CC: sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
patch
none
patch without WKSize sam: review+

Alice Liu
Reported 2011-03-10 17:51:53 PST
a WKImage can provide its image data as a CGImageRef (via WKImageCreateCGImage), but we don't have the ability to go the other way around, to create a WKImage from CGImage data.
Attachments
patch (2.30 KB, patch)
2011-03-10 19:37 PST, Alice Liu 		no flags
DetailsFormatted DiffDiff
patch without WKSize (2.33 KB, patch)
2011-03-11 02:51 PST, Alice Liu 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alice Liu
Comment 1 2011-03-10 19:37:44 PST
Created attachment 85426 [details] patch
Sam Weinig
Comment 2 2011-03-10 21:37:09 PST
Comment on attachment 85426 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=85426&action=review > Source/WebKit2/Shared/API/c/cg/WKImageCG.h:31 > +#include <WebKit2/WKImage.h> This include should not be necessary. If it is, please sort these. > Source/WebKit2/Shared/API/c/cg/WKImageCG.h:40 > +WK_EXPORT WKImageRef WKImageCreateFromCGImage(CGImageRef imageRef, WKSize size, WKImageOptions options); Why not just get the size from the CGImageRef?
Alice Liu
Comment 3 2011-03-11 02:51:17 PST
Created attachment 85453 [details] patch without WKSize the inclusion of WKImage.h is needed for WKImageOptions.
Alice Liu
Comment 4 2011-03-14 17:49:32 PDT
committed http://trac.webkit.org/projects/webkit/changeset/81087
Note You need to log in before you can comment on or make changes to this bug.