Bug 56141
Summary: | REGRESSION(r74538): 140% slowdown on scrolling-boxes demo. | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> |
Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED INVALID | ||
Severity: | Normal | CC: | aestes, ariya.hidayat, eric, hyatt, jamesr, koivisto, mitz, noam, simon.fraser |
Priority: | P1 | Keywords: | InRadar, Regression |
Version: | 528+ (Nightly build) | ||
Hardware: | Mac (Intel) | ||
OS: | OS X 10.6 | ||
URL: | http://people.mozilla.org/~roc/scrolling-boxes.html |
Ryosuke Niwa
Using r80210, the following demo takes 8619ms whereas it only takes 2505ms on Safari 5
http://people.mozilla.org/~roc/scrolling-boxes.html
Attachments | ||
---|---|---|
Add attachment proposed patch, testcase, etc. |
Ryosuke Niwa
r73316: ok
r74228: ok
r75294: bad
r75891: bad
r76640: bad
Alexey Proskuryakov
<rdar://problem/9119011>
Andy Estes
It seems like there have been multiple regressions. Due to one of these two changes:
http://trac.webkit.org/changeset/74538
http://trac.webkit.org/changeset/74539
I see a 140% slowdown (~2000ms to ~4800ms).
There is another slowdown somewhere between r74539 and ToT, which gets times ~8000ms. I'll see if I can track down that regression as well.
Andy Estes
The second regression is due to <http://trac.webkit.org/changeset/77101> I think.
Andy Estes
The first regression is caused by <http://trac.webkit.org/changeset/74538>, which turned on support for non-prefixed box-shadow.
Andy Estes
I filed <https://bugs.webkit.org/show_bug.cgi?id=56162> to track the second slowdown.
Andy Estes
The demo uses non-prefixed box-shadow, so presumably if it had used -webkit-box-shadow instead, this demo would have been slower in Safari 5 as well. Since we just weren't applying the box-shadow before r74538, this doesn't seem like an actual regression.
I think <https://bugs.webkit.org/show_bug.cgi?id=56162> is still valid though, especially since r77101 claims to improve scroll performance.
Andy Estes
Yea, Safari 5 gets the same performance numbers as r74538 if I change the test to use -webkit-box-shadow instead of box-shadow.
Andy Estes
I think that fact makes this bug invalid, but <https://bugs.webkit.org/show_bug.cgi?id=56162> still seems like a legitimate regression.
Ryosuke Niwa
Thanks for the analysis, Andy!