Bug 56141

Summary: REGRESSION(r74538): 140% slowdown on scrolling-boxes demo.
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: aestes, ariya.hidayat, eric, hyatt, jamesr, koivisto, mitz, noam, simon.fraser
Priority: P1 Keywords: InRadar, Regression
Version: 528+ (Nightly build)   
Hardware: Mac (Intel)   
OS: OS X 10.6   
URL: http://people.mozilla.org/~roc/scrolling-boxes.html

Ryosuke Niwa
Reported 2011-03-10 13:40:43 PST
Using r80210, the following demo takes 8619ms whereas it only takes 2505ms on Safari 5 http://people.mozilla.org/~roc/scrolling-boxes.html
Attachments
Ryosuke Niwa
Comment 1 2011-03-10 13:46:23 PST
r73316: ok r74228: ok r75294: bad r75891: bad r76640: bad
Alexey Proskuryakov
Comment 2 2011-03-10 17:21:50 PST
Andy Estes
Comment 3 2011-03-10 17:47:11 PST
It seems like there have been multiple regressions. Due to one of these two changes: http://trac.webkit.org/changeset/74538 http://trac.webkit.org/changeset/74539 I see a 140% slowdown (~2000ms to ~4800ms). There is another slowdown somewhere between r74539 and ToT, which gets times ~8000ms. I'll see if I can track down that regression as well.
Andy Estes
Comment 4 2011-03-10 17:51:07 PST
The second regression is due to <http://trac.webkit.org/changeset/77101> I think.
Andy Estes
Comment 5 2011-03-10 18:46:33 PST
The first regression is caused by <http://trac.webkit.org/changeset/74538>, which turned on support for non-prefixed box-shadow.
Andy Estes
Comment 6 2011-03-10 18:53:35 PST
I filed <https://bugs.webkit.org/show_bug.cgi?id=56162> to track the second slowdown.
Andy Estes
Comment 7 2011-03-10 19:01:58 PST
The demo uses non-prefixed box-shadow, so presumably if it had used -webkit-box-shadow instead, this demo would have been slower in Safari 5 as well. Since we just weren't applying the box-shadow before r74538, this doesn't seem like an actual regression. I think <https://bugs.webkit.org/show_bug.cgi?id=56162> is still valid though, especially since r77101 claims to improve scroll performance.
Andy Estes
Comment 8 2011-03-10 19:07:56 PST
Yea, Safari 5 gets the same performance numbers as r74538 if I change the test to use -webkit-box-shadow instead of box-shadow.
Andy Estes
Comment 9 2011-03-10 19:09:58 PST
I think that fact makes this bug invalid, but <https://bugs.webkit.org/show_bug.cgi?id=56162> still seems like a legitimate regression.
Ryosuke Niwa
Comment 10 2011-03-10 19:56:02 PST
Thanks for the analysis, Andy!
Note You need to log in before you can comment on or make changes to this bug.