Bug 56125

Summary: [GTK] [Webkit2] There are no scrollbars visible in the MiniBrowser
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: alex, xan.lopez
Priority: P3 Keywords: Gtk
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Activate WebCore ScrollView for WebKit2GTK+
none
Version of this patch with properly uses the WTF prefix for defines none

Martin Robinson
Reported 2011-03-10 11:23:46 PST
Scrollbars are not visible in the MiniBrowser. This is due to the fact that WebCore assumes that the widget will be in a parent GtkScrolledWindow. This is the not the way that WebKit2 operates at this time.
Attachments
Activate WebCore ScrollView for WebKit2GTK+ (3.61 KB, patch)
2011-03-10 11:31 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Version of this patch with properly uses the WTF prefix for defines (3.61 KB, patch)
2011-03-10 12:30 PST, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2011-03-10 11:31:52 PST
Created attachment 85354 [details] Activate WebCore ScrollView for WebKit2GTK+
Alejandro G. Castro
Comment 2 2011-03-10 11:50:10 PST
Comment on attachment 85354 [details] Activate WebCore ScrollView for WebKit2GTK+ View in context: https://bugs.webkit.org/attachment.cgi?id=85354&action=review Nice :), I tested it and works well. > Source/WebCore/GNUmakefile.am:3884 > +if !ENABLE_WEBKIT2 > +FEATURE_DEFINES += USE_NATIVE_GTK_MAIN_FRAME_SCROLLBAR=1 > +webcore_cppflags += -DUSE_NATIVE_GTK_MAIN_FRAME_SCROLLBAR=1 > +endif # END WEBKIT2 After bug 55996, I was wondering if we should use WTF_USE. Did not have time to check it.
Martin Robinson
Comment 3 2011-03-10 12:30:33 PST
Created attachment 85369 [details] Version of this patch with properly uses the WTF prefix for defines
Xan Lopez
Comment 4 2011-03-10 12:39:29 PST
Comment on attachment 85369 [details] Version of this patch with properly uses the WTF prefix for defines OK you guys.
Martin Robinson
Comment 5 2011-03-10 15:41:52 PST
Committed r80775: <http://trac.webkit.org/changeset/80775>
Note You need to log in before you can comment on or make changes to this bug.