Bug 56112
| Summary: | Web Inspector: Heavy Profile view should only include leaf functions as top-level nodes (affects Leaks Viewer) | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> |
| Component: | Web Inspector (Deprecated) | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED INVALID | ||
| Severity: | Normal | CC: | apavlov, bburg, bweinstein, joepeck, keishi, loislo, pfeldman, pmuellr, rik, yurys |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
Adam Roben (:aroben)
Go to <http://build.webkit.org/LeaksViewer/?url=http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r80718%20(15466)/DumpRenderTree11-leaks.txt>. In Heavy view, there is only 1 top-level node with a non-zero self count (malloc_zone_malloc). All the other top-level nodes have 0 self counts. It's not useful to show them; all those nodes show up as children of the malloc_zone_malloc node.
I think we should just omit top-level nodes with 0 self counts in Heavy view.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Roben (:aroben)
I think this is actually a bug in the Inspector's Heavy profile view. This page gives a good description of how it's supposed to work:
http://developer.apple.com/library/mac/#documentation/DeveloperTools/Conceptual/SharkUserGuide/AdvancedProfileAnalysisandDataMining/AdvancedProfileAnalysisandDataMining.html#//apple_ref/doc/uid/TP40005233-CH7-SW2
> As you can see, the “heavy” view starts from the leaf functions and builds towards the base of the callstack
Any functions that are not leaf functions should not be shown as top-level nodes in the Heavy view.