Bug 56103 – [WK2] Handle keyboard and mouse events on X11

• Component: WebKit2
• Status: RESOLVED FIXED

[Balazs Kelemen]

... so I can play Super Mario in MiniBrowser :)

[Balazs Kelemen]

Created attachment 85330 [details]
Patch

[Early Warning System Bot]

Attachment 85330 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8127037

[Balazs Kelemen]

Created attachment 85342 [details]
Patch

[Balazs Kelemen]

Tested with flash game. Unfortunately something goes wrong when loading
the plugin with almost all game as opposed to videos that works all the time.
Finally I find one to test with: http://www.pouetpu-games.com/index.php?section=2&game_id=1&w=640&h=480.
Plain old Super Mario game :)
Loading fix is not subject of this patch.

[Andreas Kling]

Comment on attachment 85342 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85342&action=review

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:261
> +    return timestampInSeconds * 1000.0;

Coding style, superfluous .0 suffix.

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:351
> +// We undefine these constants in npruntime_internal.h to avoid collosion

Typo, collision.

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:356
> +const int kKeyPressType = 2;
> +const int kKeyReleaseType = 3;
> +const int kFocusInType = 9;
> +const int kFocusOutType = 10;

Not a huge fan of these. Guess it's unavoidable though.

> Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:415
> +    ASSERT(event.type() == WebEvent::KeyDown || event.type() == WebEvent::KeyUp); // We don't generate other types.

Are you sure we don't generate other types?

[Balazs Kelemen]

Created attachment 86492 [details]
Patch

[Balazs Kelemen]

(In reply to comment #5)
> (From update of attachment 85342 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=85342&action=review
> 
> > Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:261
> > +    return timestampInSeconds * 1000.0;
> 
> Coding style, superfluous .0 suffix.
Fixed.
> 
> > Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:351
> > +// We undefine these constants in npruntime_internal.h to avoid collosion
> 
> Typo, collision.
Fixed.
> 
> > Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:356
> > +const int kKeyPressType = 2;
> > +const int kKeyReleaseType = 3;
> > +const int kFocusInType = 9;
> > +const int kFocusOutType = 10;
> 
> Not a huge fan of these. Guess it's unavoidable though.
Yes we these to make it compiling.
> 
> > Source/WebKit2/WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:415
> > +    ASSERT(event.type() == WebEvent::KeyDown || event.type() == WebEvent::KeyUp); // We don't generate other types.
> 
> Are you sure we don't generate other types?
Yes. Check WebEventFactory. Extended the comment to refer to that.

[Andreas Kling]

Comment on attachment 86492 [details]
Patch

Kool. r=me

[Balazs Kelemen]

Comment on attachment 86492 [details]
Patch

Clearing flags on attachment: 86492

Committed r81811: <http://trac.webkit.org/changeset/81811>

[Balazs Kelemen]

All reviewed patches have been landed.  Closing bug.