Summary: | selectionStart reports wrong caret position when the last characters are newlines | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||||
Component: | Forms | Assignee: | Ryosuke Niwa <rniwa> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | adele, ap, darin, enrica, ojan, tkent | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Ryosuke Niwa
2011-03-09 16:33:36 PST
Created attachment 85260 [details]
demo
This is a failed attempt to write a layout out for this bug. It seems like the bug can be reproduced only if we ran it manually.
Created attachment 85262 [details]
fixes the bug
Comment on attachment 85262 [details] fixes the bug View in context: https://bugs.webkit.org/attachment.cgi?id=85262&action=review > Source/WebCore/editing/SelectionController.cpp:171 > + // See https://bugs.webkit.org/show_bug.cgi?id=56061 nit: I feel the bug entry doesn't have additional information and ChangeLog is enough. (In reply to comment #3) > (From update of attachment 85262 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=85262&action=review > > > Source/WebCore/editing/SelectionController.cpp:171 > > + // See https://bugs.webkit.org/show_bug.cgi?id=56061 > > nit: I feel the bug entry doesn't have additional information and ChangeLog is enough. Ok. Do you think I can also get rid of the line above where I say "// Even if selection was not changed, selection offset may have been changed." ? (In reply to comment #4) > Do you think I can also get rid of the line above where I say "// Even if selection was not changed, selection offset may have been changed." ? No. This line looks helpful. (In reply to comment #5) > (In reply to comment #4) > > Do you think I can also get rid of the line above where I say "// Even if selection was not changed, selection offset may have been changed." ? > > No. This line looks helpful. Ok. Thanks for the review. Landing it now. Committed r80679: <http://trac.webkit.org/changeset/80679> |