Bug 56026

Summary: Make sure orientation is included in all places in FontPlatformDataLinux
Product: WebKit Reporter: Dave Hyatt <hyatt>
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: RESOLVED FIXED    
Severity: Normal CC: webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
dglazkov: review+
Patch
darin: review+
Sorry one more. Just completing it.
dglazkov: review+
No really. This time I *really* mean it. darin: review+

Dave Hyatt
Reported 2011-03-09 10:30:54 PST
Make sure orientation is included in all places in FontPlatformDataLinux
Attachments
Patch (1.80 KB, patch)
2011-03-09 10:31 PST, Dave Hyatt 		dglazkov: review+
DetailsFormatted DiffDiff
Patch (5.15 KB, patch)
2011-03-09 10:42 PST, Dave Hyatt 		darin: review+
DetailsFormatted DiffDiff
Sorry one more. Just completing it. (6.68 KB, patch)
2011-03-09 10:54 PST, Dave Hyatt 		dglazkov: review+
DetailsFormatted DiffDiff
No really. This time I *really* mean it. (7.47 KB, patch)
2011-03-09 11:06 PST, Dave Hyatt 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Dave Hyatt
Comment 1 2011-03-09 10:31:16 PST
Created attachment 85191 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2011-03-09 10:32:25 PST
Comment on attachment 85191 [details] Patch activate Varon-T disruptors!
Dave Hyatt
Comment 3 2011-03-09 10:42:36 PST
Created attachment 85194 [details] Patch
WebKit Review Bot
Comment 4 2011-03-09 10:43:41 PST
Attachment 85194 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1 Source/WebCore/platform/graphics/chromium/FontPlatformDataLinux.h:95: The parameter name "orientation" adds no information, so it should be removed. [readability/parameter_name] [5] Source/WebCore/platform/graphics/chromium/FontPlatformDataLinux.h:95: The parameter name "textOrientation" adds no information, so it should be removed. [readability/parameter_name] [5] Total errors found: 2 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 5 2011-03-09 10:52:34 PST
Comment on attachment 85194 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85194&action=review >>> Source/WebCore/platform/graphics/chromium/FontPlatformDataLinux.h:95 >>> + FontPlatformData(SkTypeface*, const char* name, float textSize, bool fakeBold, bool fakeItalic, FontOrientation orientation = Horizontal, TextOrientation textOrientation = TextOrientationVerticalRight); >> >> The parameter name "orientation" adds no information, so it should be removed. [readability/parameter_name] [5] > > The parameter name "textOrientation" adds no information, so it should be removed. [readability/parameter_name] [5] I agree with the style bot!
Dave Hyatt
Comment 6 2011-03-09 10:54:56 PST
Created attachment 85196 [details] Sorry one more. Just completing it.
Dimitri Glazkov (Google)
Comment 7 2011-03-09 10:56:35 PST
Comment on attachment 85196 [details] Sorry one more. Just completing it. rs=me.
Dave Hyatt
Comment 8 2011-03-09 11:06:59 PST
Created attachment 85198 [details] No really. This time I *really* mean it.
Dave Hyatt
Comment 9 2011-03-09 11:24:00 PST
Fixed.
Note You need to log in before you can comment on or make changes to this bug.