Bug 55992

Summary: Prepare to move full screen animation into WebCore.
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: WebKit Misc.Assignee: Jer Noble <jer.noble>
Status: RESOLVED WONTFIX    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch none

Jer Noble
Reported 2011-03-08 21:35:51 PST
The animation into and out of full screen mode currently lives in WebKit. Instead of duplicating code into WebKit2, the animation code should be moved down into WebCore. Add new APIs to trigger the fullscreen animation and report the animation status back up to WebKit and WebKit2.
Attachments
Patch (4.09 KB, patch)
2011-03-08 22:53 PST, Jer Noble 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2011-03-08 22:53:10 PST
Created attachment 85133 [details] Patch
Jer Noble
Comment 2 2011-03-11 01:28:50 PST
Comment on attachment 85133 [details] Patch Removing r? for now; I think the Document::beginEnterFullScreenAnimation may end up being unnecessary.
Jer Noble
Comment 3 2011-03-11 09:47:57 PST
It looks like animation won't be moved into WebCore, due to the fact that generated renderers cannot (currently) animate.
Note You need to log in before you can comment on or make changes to this bug.