Summary: | Move StyleChange and other global functions from ApplyStyleCommand to EditingStyle | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Ryosuke Niwa <rniwa> | ||||
Component: | HTML Editing | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Enhancement | CC: | commit-queue, darin, eric, morrita | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 54932 | ||||||
Attachments: |
|
Description
Ryosuke Niwa
2011-03-08 15:02:09 PST
Created attachment 85098 [details]
cleanup
Although I don't know the context of this change, The change itself looks trivial and ready to r+. Comment on attachment 85098 [details]
cleanup
OK.
Comment on attachment 85098 [details] cleanup Rejecting attachment 85098 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 2 Last 500 characters of output: ce/WebCore/editing/ApplyStyleCommand.cpp Hunk #2 FAILED at 49. Hunk #3 succeeded at 111 (offset -2 lines). 1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/editing/ApplyStyleCommand.cpp.rej patching file Source/WebCore/editing/ApplyStyleCommand.h patching file Source/WebCore/editing/EditingStyle.cpp patching file Source/WebCore/editing/EditingStyle.h Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/8386637 Committed r83618: <http://trac.webkit.org/changeset/83618> |