Bug 55974

Summary: Move StyleChange and other global functions from ApplyStyleCommand to EditingStyle
Product: WebKit Reporter: Ryosuke Niwa <rniwa>
Component: HTML EditingAssignee: Nobody <webkit-unassigned>
Severity: Enhancement CC: commit-queue, darin, eric, morrita
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 54932    
Description Flags
cleanup eric: review+, commit-queue: commit-queue-

Description Ryosuke Niwa 2011-03-08 15:02:09 PST
ApplyStyleCommand.cpp currently hosts many style-related functions but they should really be in EditingStyle instead.
Comment 1 Ryosuke Niwa 2011-03-08 15:21:22 PST
Created attachment 85098 [details]
Comment 2 Hajime Morrita 2011-04-11 14:10:41 PDT
Although I don't know the context of this change, The change itself looks trivial and ready to r+.
Comment 3 Eric Seidel (no email) 2011-04-11 15:01:38 PDT
Comment on attachment 85098 [details]

Comment 4 WebKit Commit Bot 2011-04-11 15:08:26 PDT
Comment on attachment 85098 [details]

Rejecting attachment 85098 [details] from commit-queue.

Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 2

Last 500 characters of output:
Hunk #2 FAILED at 49.
Hunk #3 succeeded at 111 (offset -2 lines).
1 out of 3 hunks FAILED -- saving rejects to file Source/WebCore/editing/ApplyStyleCommand.cpp.rej
patching file Source/WebCore/editing/ApplyStyleCommand.h
patching file Source/WebCore/editing/EditingStyle.cpp
patching file Source/WebCore/editing/EditingStyle.h

Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Eric Seidel', u'--force']" exit_code: 1

Full output: http://queues.webkit.org/results/8386637
Comment 5 Ryosuke Niwa 2011-04-12 12:02:16 PDT
Committed r83618: <http://trac.webkit.org/changeset/83618>