Bug 55959 – REGRESSION (WebKit2): VoiceOver focus no longer follows keyboard focus

• Component: Accessibility
• Status: RESOLVED FIXED

[chris fleizach]

When focus changes, VoiceOver does not follow in WK2

[chris fleizach]

Created attachment 85097 [details]
patch

[chris fleizach]

Created attachment 85116 [details]
patch

first patch didn't svn apply

[chris fleizach]

Created attachment 85117 [details]
patch

[chris fleizach]

Created attachment 85206 [details]
patch

[Build Bot]

Attachment 85206 [details] did not build on win:
Build output: http://queues.webkit.org/results/8117576

[Early Warning System Bot]

Attachment 85206 [details] did not build on qt:
Build output: http://queues.webkit.org/results/8110964

[chris fleizach]

Created attachment 85250 [details]
patch

[Darin Adler]

Comment on attachment 85250 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=85250&action=review

> Source/WebKit2/WebProcess/WebProcess.cpp:465
> +#if PLATFORM(MAC)
> +    Vector<RefPtr<WebPage> > pages;
> +    copyValuesToVector(m_pageMap, pages);
> +    for (size_t i = 0; i < pages.size(); ++i)
> +        if (pages[i]->windowIsFocused())
> +            return pages[i].get();
> +#endif
> +    return 0;

Is always zero correct for non-Mac platforms? Or is this just not implemented for those platforms? Can’t we just compile this function on all platforms? If we are having some problem compiling it on some of those other platforms where it’s also not called, we could just put the #if around the entire function definition instead, which I think would be clearer.

Do we really need to copy the map to a vector? Why can’t we just iterate the map? Can the windowIsFocused function change the contents of the map?

Need braces around the body of the for loop.

> Source/WebKit2/WebProcess/mac/NSApplicationOverride.mm:32
> +@implementation NSApplication (NSApplicationOverride)

Defining a category is not a reliable way to override the implementation of a method in an AppKit class even though it often seems to work. The reliable method involves method_setImplementation and is done in source files such as WebPluginController.mm, WebHTMLView.mm, and WebView.mm in WebKit.

> Source/WebKit2/WebProcess/mac/NSApplicationOverride.mm:39
> +    if (!WebKit::WebProcess::shared().isSeparateProcess())

It’s normally better to put using namespace WebKit at the start of a file rather than doing WebKit:: everywhere.

[chris fleizach]

Created attachment 85405 [details]
patch

[chris fleizach]

http://trac.webkit.org/changeset/80789