Bug 55934

Summary: [GTK] Implement ResourceRequest and ResourceResponse encoder/decoder
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson, svillar, sy302.park, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
patch for ResourceRequest and ResourceResponse encoder/decoder none

Description Alejandro G. Castro 2011-03-08 04:22:44 PST 
We have to implement the proper encoder and decoder to make the policy work, currently we just have a stub to make the communication work, check:

  - Source/WebKit2/Shared/gtk/WebCoreArgumentCodersGtk.cpp
Comment 1 SangYong Park 2011-06-14 23:32:27 PDT 
Would you like to make patch for this bug? if not, can I make it?
Comment 2 Alejandro G. Castro 2011-06-15 00:09:48 PDT 
(In reply to comment #1)
> Would you like to make patch for this bug? if not, can I make it?

Please go ahead :), thanks.
Comment 3 SangYong Park 2011-06-15 03:41:32 PDT 
Created attachment 97270 [details]
patch for ResourceRequest and ResourceResponse encoder/decoder
Comment 4 Martin Robinson 2011-06-15 08:51:55 PDT 
CCing svillar who might have some opinions about whether or not it be good to do this with gvariant.
Comment 5 Sergio Villar Senin 2011-06-16 07:53:37 PDT 
(In reply to comment #4)
> CCing svillar who might have some opinions about whether or not it be good to do this with gvariant.

I'd say, if we have tools in WebKit to do it then let's do it that way. Doing it with GVariant wouldn't outcome simpler code.
Comment 6 Martin Robinson 2011-06-16 08:14:33 PDT 
Comment on attachment 97270 [details]
patch for ResourceRequest and ResourceResponse encoder/decoder

Okay. Seems sane!
Comment 7 WebKit Review Bot 2011-06-16 09:03:27 PDT 
Comment on attachment 97270 [details]
patch for ResourceRequest and ResourceResponse encoder/decoder

Clearing flags on attachment: 97270

Committed r89030: <http://trac.webkit.org/changeset/89030>
Comment 8 WebKit Review Bot 2011-06-16 09:03:31 PDT 
All reviewed patches have been landed.  Closing bug.