Bug 55934

Summary: [GTK] Implement ResourceRequest and ResourceResponse encoder/decoder
Product: WebKit Reporter: Alejandro G. Castro <alex>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: mrobinson, svillar, sy302.park, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
patch for ResourceRequest and ResourceResponse encoder/decoder none

Alejandro G. Castro
Reported 2011-03-08 04:22:44 PST
We have to implement the proper encoder and decoder to make the policy work, currently we just have a stub to make the communication work, check: - Source/WebKit2/Shared/gtk/WebCoreArgumentCodersGtk.cpp
Attachments
patch for ResourceRequest and ResourceResponse encoder/decoder (7.13 KB, patch)
2011-06-15 03:41 PDT, SangYong Park 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
SangYong Park
Comment 1 2011-06-14 23:32:27 PDT
Would you like to make patch for this bug? if not, can I make it?
Alejandro G. Castro
Comment 2 2011-06-15 00:09:48 PDT
(In reply to comment #1) > Would you like to make patch for this bug? if not, can I make it? Please go ahead :), thanks.
SangYong Park
Comment 3 2011-06-15 03:41:32 PDT
Created attachment 97270 [details] patch for ResourceRequest and ResourceResponse encoder/decoder
Martin Robinson
Comment 4 2011-06-15 08:51:55 PDT
CCing svillar who might have some opinions about whether or not it be good to do this with gvariant.
Sergio Villar Senin
Comment 5 2011-06-16 07:53:37 PDT
(In reply to comment #4) > CCing svillar who might have some opinions about whether or not it be good to do this with gvariant. I'd say, if we have tools in WebKit to do it then let's do it that way. Doing it with GVariant wouldn't outcome simpler code.
Martin Robinson
Comment 6 2011-06-16 08:14:33 PDT
Comment on attachment 97270 [details] patch for ResourceRequest and ResourceResponse encoder/decoder Okay. Seems sane!
WebKit Review Bot
Comment 7 2011-06-16 09:03:27 PDT
Comment on attachment 97270 [details] patch for ResourceRequest and ResourceResponse encoder/decoder Clearing flags on attachment: 97270 Committed r89030: <http://trac.webkit.org/changeset/89030>
WebKit Review Bot
Comment 8 2011-06-16 09:03:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.