[GTK] Add proxy support to GtkLauncher

• Component: Tools / Tests
• Status: RESOLVED WONTFIX

Hello,

We are using GtkLauncher and we want to  access to internet via proxy.

I'll attach a patch that will help to do it.

Regards,
Thouraya.

Created attachment 85037 [details]
Add proxy support to GtkLauncher

[Collabora GTK+ EWS bot]

Attachment 85037 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/8106768

Created attachment 85045 [details]
Add proxy support to GtkLauncher

Hello,

I'm working on Linux and I built GtkLauncher successfully without any undefined reference symbol.

In the attached patch I added LIBSOUP_LIBS flag to Programs_GtkLauncher_LDADD to fix the undefined symbol you had.

Regards.

[Martin Robinson]

Comment on attachment 85045 [details]
Add proxy support to GtkLauncher

Wouldn't it make more sense to simply add the  SOUP_TYPE_PROXY_RESOLVER_GNOME feature to the session?

[Martin Robinson]

Renaming this bug, since I think it's unrelated to the web inspector.

[thouraya]

(In reply to comment #4)
> (From update of attachment 85045 [details])
> Wouldn't it make more sense to simply add the  SOUP_TYPE_PROXY_RESOLVER_GNOME feature to the session?

Hello,

We cannot do it because we are not using libsoup-gnome and cross-compiling it because it may depend on another gnome libraries.

Regards,
Thouraya.

[Gustavo Noronha (kov)]

We can now use the new SoupProxyResolverDefault: https://bugzilla.gnome.org/show_bug.cgi?id=642928

[Gustavo Noronha (kov)]

Comment on attachment 85045 [details]
Add proxy support to GtkLauncher

View in context: https://bugs.webkit.org/attachment.cgi?id=85045&action=review

This patch does too many things in one go, going way beyong 'adding proxy support' - it would at least need to be broken up in two or three patches that each do its thing. I also don't like the idea of reinventing argument parsing inside GtkLauncher.  So, to be clear:

1. If we want proxy support, I am OK with using the new default proxy resolver included in libsoup: https://bugzilla.gnome.org/show_bug.cgi?id=642928
2. I'm fine with options to request different width/height, but that should be a separate patch and use glib's option parsing infrastructure, no manual arguments parsing
3. The changes to how webkit_web_view_load_uri is apparently gain us nothing while removing the ability to give GtkLauncher a filename

> Tools/GtkLauncher/main.c:359
> -    gchar *uri =(gchar*)(argc > 1 ? argv[1] : "http://www.google.com/");
> -    gchar *fileURL = filenameToURL(uri);
> -
> -    webkit_web_view_load_uri(webView, fileURL ? fileURL : uri);
> -    g_free(fileURL);
> +    webkit_web_view_load_uri(webView, uri);

This seems to be totally unrelated?

[thouraya]

Created attachment 87165 [details]
Add options to request width & height in GtkLauncher

Hello,

Attached a patch adding options to request width & height in GtkLauncher.

Regards,
Thouraya.

[Martin Robinson]

Comment on attachment 87165 [details]
Add options to request width & height in GtkLauncher

View in context: https://bugs.webkit.org/attachment.cgi?id=87165&action=review

What's the use case for wanting to pass in width and height parameters to GTK+ launcher?

> Tools/ChangeLog:6
> +        Add options to request width/height in GtkLauncher.
> +        https://bugs.webkit.org/show_bug.cgi?id=55929

This is not actually the description in the bug. Probably either this change should be moved to another bug or you should rename this one.

[thouraya]

Hello,


(In reply to comment #10)
> (From update of attachment 87165 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=87165&action=review
> 
> What's the use case for wanting to pass in width and height parameters to GTK+ launcher?

Because in Set top boxes there is no mouse to resize the window, and it's better to give customers the ability to do it.

> 
> > Tools/ChangeLog:6
> > +        Add options to request width/height in GtkLauncher.
> > +        https://bugs.webkit.org/show_bug.cgi?id=55929
> 
> This is not actually the description in the bug. Probably either this change should be moved to another bug or you should rename this one.

[thouraya]

Hello,


(In reply to comment #7)
> We can now use the new SoupProxyResolverDefault: https://bugzilla.gnome.org/show_bug.cgi?id=642928

To add proxy support, I have only to add 3 lines:

SoupSession * ss = webkit_get_default_session();
proxyUri = soup_uri_new(proxy);
g_object_set(ss, SOUP_SESSION_PROXY_URI, proxyUri, NULL);


Why shoold I replace them using SoupProxyResolverDefault?
the problem is in the call to g_object_set()?


Using that API, how to set the proxy property to the session?
I won't use soup_session_async_new_with_options ( the session is already created) and I cannot add it as a new feature to the session.

Thank you very much.
Thouraya.

[Martin Robinson]

(In reply to comment #11)
> > What's the use case for wanting to pass in width and height parameters to GTK+ launcher?
> Because in Set top boxes there is no mouse to resize the window, and it's better to give customers the ability to do it.

GtkLauncher is not meant to be shipped as a browser. It's really just an example of a very basic WebKit embed for developers. It's missing a lot of functionality that a useful browser requires. If you need to ship software for your customers, please create a separate, standalone browser.

[thouraya]

Hello,

(In reply to comment #13)
> (In reply to comment #11)
> > > What's the use case for wanting to pass in width and height parameters to GTK+ launcher?
> > Because in Set top boxes there is no mouse to resize the window, and it's better to give customers the ability to do it.
> 
> GtkLauncher is not meant to be shipped as a browser. It's really just an example of a very basic WebKit embed for developers. It's missing a lot of functionality that a useful browser requires. If you need to ship software for your customers, please create a separate, standalone browser.


Thank you for the response.

Regards.

[Ryuan Choi]

(In reply to comment #13)
> (In reply to comment #11)
> > > What's the use case for wanting to pass in width and height parameters to GTK+ launcher?
> > Because in Set top boxes there is no mouse to resize the window, and it's better to give customers the ability to do it.
> 
> GtkLauncher is not meant to be shipped as a browser. It's really just an example of a very basic WebKit embed for developers. It's missing a lot of functionality that a useful browser requires. If you need to ship software for your customers, please create a separate, standalone browser.

Hello,
I am waiting this bug to get proxy support to Gtklauncher.

As you mentioned,
Gtklauncher is a good example for developer to test.
And I want to contribute something for WebKit/Gtk if I can.
But, I need to add proxy information to test Gtklauncher every time, because I am behind of proxy.

I just want simple patch to add proxy via env.
EWeblauncher already have it.
If you are agree, I can propose a patch.

[Martin Robinson]

(In reply to comment #15)
> As you mentioned, Gtklauncher is a good example for developer to test.  And I want to contribute something for WebKit/Gtk if I can.  But, I need to add proxy information to test Gtklauncher every time, because I am behind of proxy.

Would adding the default soup proxy resolver to the session, as discussed earlier, fulfill your needs? If so, I'd be willing to r+ the patch.

[Eric Seidel (no email)]

Comment on attachment 87165 [details]
Add options to request width & height in GtkLauncher

Cleared review? from attachment 87165 [details] so that this bug does not appear in http://webkit.org/pending-review.  If you would like this patch reviewed, please attach it to a new bug (or re-open this bug before marking it for review again).