Bug 55928
| Summary: | Add Ajax tests to jQuery test suite in layout tests | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mathias Bynens <mathias> |
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth, mathias, paulirish |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | OS X 10.6 | ||
Mathias Bynens
This is a follow-up to bug 55911. The jQuery test suite has been added to WebKit’s layout tests, but it seems the Ajax tests are missing. Apparently this was intentional, because they don’t seem to run locally — but it sounds like there’s a workaround. IRC log:
[09:40] <matjas> abarth: ping
[09:40] <abarth> hi
[09:41] <abarth> what can i do for you?
[09:41] <matjas> about the jQuery test case getting included in the layout tests (http://trac.webkit.org/changeset/80511)
[09:41] <abarth> yes
[09:42] <matjas> well, paul_irish noticed that it’s missing an ajax.html and ajax-expected.txt
[09:42] <matjas> abarth: is this one of the necessary changes dglazkov mentioned?
[09:42] <abarth> yeah, they don't seem to run "locally"
[09:42] <matjas> abarth: i see
[09:42] <paul_irish> locally like file:// scheme?
[09:43] <abarth> http://trac.webkit.org/browser/trunk/LayoutTests/jquery/resources/test/unit/ajax.js#L8
[09:43] <abarth> i didn't look into why isLocal is true
[09:43] <abarth> but it probably keys off the file scheme
[09:44] <paul_irish> yup.
[09:44] <abarth> we'd certainly like to run those tests
[09:44] <abarth> we can run them as http tests
[09:44] <abarth> they'll just be a bit slower
[09:45] <abarth> data/errorWithText.php
[09:45] <abarth> looks like they use PHP
[09:45] <abarth> we have a PHP interpretor in the http tets
[09:45] <abarth> tests
[09:45] <abarth> so that should be fine
[09:52] <abarth> matjas: the only change I made to the test suite proper was to add a postMessage to top when the tests were over (and to add an XSS hole to let me select which of the test groups to run)
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Adam Barth
Patches welcome. :)
This actually should be pretty straightforward to fix. We can try moving the whole test suite over to HTTP. The only downside of that is that it might be slow.