| Summary: | Make LayoutTests robust to latency btwn playing event and frame rendering | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Victoria Kirst <vrk> | ||||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | UNCONFIRMED --- | ||||||||||
| Severity: | Normal | CC: | annacc, commit-queue, imasaki, mihaip | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Victoria Kirst
2011-03-07 19:39:23 PST
Created attachment 85011 [details]
Patch
These layout tests depended on the play event firing immediately after a call to play(). I added logic to pause and seek so that the pixel results will always be consistent. Rebaselines will come after this patch is committed. See crbug.com/74982 Comment on attachment 85011 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85011&action=review > LayoutTests/media/controls-after-reload.html:14 > + video.pause(); Do the pause/currentTime lines have to be inside the "if (window.layoutTestController)" blocks? Generally we want layout tests to behave the same way when run inside the DRT as when they're run inside a normal browser. > LayoutTests/platform/chromium/test_expectations.txt:3059 > +// Temporarily make these tests flaky. Why is this necessary? If you leave them as having just IMAGE expectations, we'll get notified when they start to unexpectedly pass. Created attachment 85219 [details]
Patch
Gah, sorry about that patch, Mihai! I must have been sleepy when I uploaded it. I have fixed the comments you mentioned (and a few other silly things) and uploaded a new one. I got rid of the GPU modifier on test_expectations.txt because this should affect both software and GPU rendered tests. Created attachment 85221 [details]
Patch
Comment on attachment 85221 [details] Patch Rejecting attachment 85221 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=eseidel-cq-sf', 'bu..." exit_code: 2 Last 500 characters of output: c3/JavaArray .... java/lc3/JavaClass .... java/lc3/JavaObject ..................................... java/lc3/StringMethods . java/lc3/forin . java/lc3/instanceof . jquery ........... loader .. mathml ....... mathml/presentation .................. media ................ media/controls-after-reload.html -> failed Exiting early after 1 failures. 13129 tests run. 383.26s total testing time 13128 test cases (99%) succeeded 1 test case (<1%) had incorrect layout 9 test cases (<1%) had stderr output Full output: http://queues.webkit.org/results/8148088 Comment on attachment 85221 [details]
Patch
Clearing review flag since this patch caused a test failure on the commit bot.
vrk@, do you have update on this? |