Bug 55912

Summary: Make adjustMIMETypeIfNecessary use CFNetwork directly
Product: WebKit Reporter: Pratik Solanki <psolanki>
Component: PlatformAssignee: Pratik Solanki <psolanki>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, ap, beidson, eric, psolanki, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 51836    
Attachments:
Description Flags
Patch beidson: review+

Pratik Solanki
Reported 2011-03-07 17:19:26 PST
In WebCoreURLResponse.mm we have a category method on NSURLResponse called adjustMIMETypeIfNecessary. This gets called from ResourceHandleMac.mm to adjust MIME types for local files. We should move that code to use CFNetwork directly. That will allow us to use the method from ResourceHandleCFNet.cpp. This is needed for bug 51836.
Attachments
Patch (491.60 KB, patch)
2011-03-07 22:42 PST, Pratik Solanki 		beidson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2011-03-07 22:42:25 PST
Created attachment 85020 [details] Patch
Pratik Solanki
Comment 2 2011-03-13 17:11:59 PDT
Committed r80975: <http://trac.webkit.org/changeset/80975>
WebKit Review Bot
Comment 3 2011-03-13 20:01:24 PDT
http://trac.webkit.org/changeset/80975 might have broken SnowLeopard Intel Release (Tests) The following tests are not passing: http/tests/incremental/slow-utf8-text.pl
Pratik Solanki
Comment 4 2011-03-13 22:59:28 PDT
Ah. There's a bug in my patch. It says test/plain when it should be text/plain.
Pratik Solanki
Comment 5 2011-03-13 23:03:04 PDT
Followup fix r81001: <http://trac.webkit.org/changeset/81001>
Pratik Solanki
Comment 6 2011-03-14 16:15:07 PDT
And another follow on change to fix the architectures in WKSI - <http://trac.webkit.org/changeset/81074>.
Note You need to log in before you can comment on or make changes to this bug.