Bug 55910

Summary: Make CodeBlock GC write barrier safe
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, buildbot, eric, ossy, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 56019    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch barraclough: review+

Oliver Hunt
Reported 2011-03-07 15:56:28 PST
Make CodeBlock GC write barrier safe
Attachments
Patch (68.56 KB, patch)
2011-03-07 16:49 PST, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (69.61 KB, patch)
2011-03-08 11:09 PST, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-03-07 16:49:44 PST
Created attachment 84997 [details] Patch
WebKit Review Bot
Comment 2 2011-03-07 16:51:25 PST
Attachment 84997 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/bytecode/EvalCodeCache.h:44: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Build Bot
Comment 3 2011-03-07 17:41:42 PST
Attachment 84997 [details] did not build on win: Build output: http://queues.webkit.org/results/8101656
Early Warning System Bot
Comment 4 2011-03-07 18:59:19 PST
Attachment 84997 [details] did not build on qt: Build output: http://queues.webkit.org/results/8105657
Oliver Hunt
Comment 5 2011-03-08 11:09:39 PST
Created attachment 85061 [details] Patch
WebKit Review Bot
Comment 6 2011-03-08 11:12:08 PST
Attachment 85061 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/JavaScriptCore/bytecode/EvalCodeCache.h:44: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 33 files If any of these errors are false positives, please file a bug against check-webkit-style.
Gavin Barraclough
Comment 7 2011-03-08 11:55:40 PST
Comment on attachment 85061 [details] Patch Please fix the ASSERTs to check JSFinalObject fully fills its allocation, and revert the JSZombie changes.
Oliver Hunt
Comment 8 2011-03-08 15:19:12 PST
Committed r80598: <http://trac.webkit.org/changeset/80598>
WebKit Review Bot
Comment 9 2011-03-08 20:18:07 PST
http://trac.webkit.org/changeset/80598 might have broken Qt Linux Release The following tests are not passing: jquery/manipulation.html
Csaba Osztrogonác
Comment 10 2011-03-09 08:47:17 PST
(In reply to comment #9) > http://trac.webkit.org/changeset/80598 might have broken Qt Linux Release > The following tests are not passing: > jquery/manipulation.html I filed a new bug on it: https://bugs.webkit.org/show_bug.cgi?id=56019
Note You need to log in before you can comment on or make changes to this bug.