Bug 55881

Summary: Split JNIBridgeJSC.cpp/h into JavaArrayJSC.cpp/h and JavaFieldJSC.cpp/h
Product: WebKit Reporter: Steve Block <steveblock>
Component: New BugsAssignee: Steve Block <steveblock>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, jorlow, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on: 55774    
Bug Blocks:    
Attachments:
Description Flags
Patch 1
none
Patch 2 jorlow: review+

Steve Block
Reported 2011-03-07 09:10:27 PST
Split JNIBridgeJSC.cpp/h into JavaArrayJSC.cpp/h and JavaFieldJSC.cpp/h
Attachments
Patch 1 (54.21 KB, patch)
2011-03-07 09:19 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
Patch 2 (54.21 KB, patch)
2011-03-07 10:17 PST, Steve Block 		jorlow: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2011-03-07 09:19:13 PST
Created attachment 84951 [details] Patch 1
Steve Block
Comment 2 2011-03-07 10:17:46 PST
Created attachment 84954 [details] Patch 2
Jeremy Orlow
Comment 3 2011-03-07 10:21:25 PST
Comment on attachment 84954 [details] Patch 2 rubber stamp = me (only skimmed)
Steve Block
Comment 4 2011-03-07 10:50:58 PST
Committed r80476: <http://trac.webkit.org/changeset/80476>
WebKit Review Bot
Comment 5 2011-03-07 11:10:44 PST
http://trac.webkit.org/changeset/80476 might have broken Qt Linux Release
Steve Block
Comment 6 2011-03-07 13:24:41 PST
Looks like the Qt build break was due to a later change - http://trac.webkit.org/changeset/80478 - not sure why my change was on the blame list. In any case, the break was fixed in http://trac.webkit.org/changeset/80480.
Note You need to log in before you can comment on or make changes to this bug.