Summary: | WebKit uses multiple conflicting names to refer to the device scale factor | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||
Component: | Layout and Rendering | Assignee: | Matthew Delaney <mdelaney7> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | aroben, bdakin, hyatt, jamesr, mdelaney7, oliver, simon.fraser, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Simon Fraser (smfr)
2011-03-04 10:55:53 PST
Created attachment 103540 [details]
Clear up scale factor terminology
Attachment 103540 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1
Source/WebKit/efl/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebKit/gtk/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebKit/haiku/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebCore/css/MediaQueryEvaluator.cpp:296: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Source/WebKit/qt/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebKit2/UIProcess/WebPopupMenuProxy.h:62: The parameter name "rect" adds no information, so it should be removed. [readability/parameter_name] [5]
Source/WebKit/mac/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebKit/win/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebKit/wx/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebKit2/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebKit/wince/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Source/WebKit/chromium/ChangeLog:1: ChangeLog entry has no bug number [changelog/bugnumber] [5]
Total errors found: 12 in 88 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 103540 [details] Clear up scale factor terminology View in context: https://bugs.webkit.org/attachment.cgi?id=103540&action=review >> Source/WebKit/chromium/ChangeLog:1 >> +2011-08-10 Adam Roben <aroben@apple.com> > > ChangeLog entry has no bug number [changelog/bugnumber] [5] I left out the bug number intentionally in all the non-WebCore ChangeLogs, since the bug is WebCore-specific. I could retitle the bug to be more generic and put it everywhere, I guess. I think people looking at their port's ChangeLogs only would appreciate that. OK, I'm retitling this bug to represent the more general problem of there being too many names that mean "the scale factor of the display on which we're rendering". HTMLCanvasElement::m_pageScaleFactor is just one part of that problem. I'll add the bug title/URL to all the ChangeLogs and land this. |