Summary: | canvas arc() missing line to start of arc if swing is zero | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Cary Clark <caryclark> | ||||||||||||||
Component: | Canvas | Assignee: | Tom Zakrajsek <tomz> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | jamesr, kling, mdelaney7, rniwa, webkit.review.bot | ||||||||||||||
Priority: | P2 | ||||||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||||||
Hardware: | All | ||||||||||||||||
OS: | All | ||||||||||||||||
Bug Depends on: | 66832 | ||||||||||||||||
Bug Blocks: | 67301 | ||||||||||||||||
Attachments: |
|
Description
Cary Clark
2011-03-03 12:09:13 PST
Created attachment 105132 [details] Patch This patch also has the fix for related bug https://bugs.webkit.org/show_bug.cgi?id=66832. Attachment 105132 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'LayoutTests/ChangeLog', u'LayoutTests/canv..." exit_code: 1
Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:830: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 105133 [details]
Patch - fix compare to 0 style error
For the record, I don't like this. Having to do a boolean check to see if a float is 0 or not, for "style" reasons, doesn't feel right.
Created attachment 105134 [details]
Patch
Comment on attachment 105133 [details] Patch - fix compare to 0 style error Attachment 105133 [details] did not pass chromium-ews (chromium-xvfb): Output: http://queues.webkit.org/results/9508238 New failing tests: canvas/philip/tests/2d.path.arc.zeroradius.html fast/canvas/canvas-arc-zero-lineto.html (In reply to comment #4) > Created an attachment (id=105134) [details] > Patch Do you want it is reviewed? If so, open "Details" page of the attachment, change MIME type, check "Patch" checkbox, and select '?' for review flag. You had better use "webkit-patch upload" script. It takes care of them. Created attachment 105183 [details]
Patch
Comment on attachment 105183 [details]
Patch
Missed a test failure from previous bot run.
Created attachment 105242 [details]
Patch
Comment on attachment 105242 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=105242&action=review > Source/WebCore/html/canvas/CanvasRenderingContext2D.cpp:834 > + FloatPoint pt(x + r * cos(sa), y + r * sin(sa)); Shouldn't that be cosf() and sinf()? Created attachment 105382 [details]
Patch
Comment on attachment 105382 [details]
Patch
LGTM.
Comment on attachment 105382 [details] Patch Clearing flags on attachment: 105382 Committed r93982: <http://trac.webkit.org/changeset/93982> All reviewed patches have been landed. Closing bug. canvas/philip/tests/2d.path.stroke.prune.arc.html started failing on Snow Leopard after this patch: http://build.webkit.org/results/SnowLeopard%20Intel%20Debug%20(Tests)/r93982%20(1898)/canvas/philip/tests/2d.path.stroke.prune.arc-pretty-diff.html |