Bug 55605
| Summary: | [Qt][Symbian] use of build-webkit triggers rebuild of QtWebkit.dll | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Mahesh Kulkarni <maheshk> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | RESOLVED FIXED | ||
| Severity: | Enhancement | CC: | benjamin, dihan.wickremasuriya, koshuin, laszlo.gombos, ossy, s.mathur |
| Priority: | P5 | Keywords: | Qt, QtTriaged |
| Version: | 528+ (Nightly build) | ||
| Hardware: | S60 Hardware | ||
| OS: | S60 3rd edition | ||
Mahesh Kulkarni
Every single pro/pri file change resulting in clean build of webkit2.
Ex: webkit\Source\WebKit2\UIProcess\API\qt\tests\tests.pro edit this file needs a qmake and then make, so running
:\webkit\Source\>perl ..\Tools\Scripts\build-webkit --qt --symbian --no-svg --makeargs=-j4 CONFIG+=webkit2
make release-armv5 resulting in clean build of entire webkit project. This may need a bug to be filed on sbs system and this bug is to keep track of the issue.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Siddharth Mathur
build-webkit causes running of qmake, which in turn regenerates .mmp file for each target. SBSv2 treats .mmp as its top-level dependendency for each target, hence it starts everything from scratch upon seeing a 'touched' .mmp.
We need to file an enhancement request with SBSv2 folks. Need this for a public Symbian buildbot too!
Csaba Osztrogonác
(In reply to comment #1)
> We need to file an enhancement request with SBSv2 folks. Need this for a public Symbian buildbot too!
+1 vote for this SBSv2 enhancement.
Benjamin Poulain
It would be nice to have, anyone contacted the SBSv2 team?
Janne Koskinen
This is not a webkit bug but a general Symbian build system issue.
Why would you call build-webkit script in a first place if you just change single pro file ? I don't see reason running the generators everytime I make a change. Raptor now has new option -pro which would be the best place to start this. I do think this will be rather large change then the toolchain.
Siddharth Mathur
(In reply to comment #3)
> It would be nice to have, anyone contacted the SBSv2 team?
Bug 201 in Raptor team's bugzilla.
Laszlo Gombos
(In reply to comment #4)
> This is not a webkit bug but a general Symbian build system issue.
> Why would you call build-webkit script in a first place ...
One reason would be a Symbian buildbot. This bug is to determine if there is anything we can do in the QtWebKit build system to manage this problem.
Siddharth Mathur
In case we are still in the market for this, Daniel J from the SBSv2 (Raptor) team just left comment in their Bugzilla:
"I've finished implementing this and this change will be available in the
version of Raptor following 2.16.4."
Siddharth Mathur
Closing this as latest SBSv2 delivers this enhancement.