Bug 55587

Summary: Support DOM memory usage estimation
Product: WebKit Reporter: Vitaly Repeshko <vitalyr>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: gregsimon, koivisto, loislo, mnaganov, pfeldman, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
WIP none

Vitaly Repeshko
Reported 2011-03-02 10:09:54 PST
It would be useful to have an estimate on the amount of memory used by DOM structures. Using this data in the heap profiler in Web Inspector we can help web developers fix leaks in their applications. The heap profiler will be able to show that e.g. a particular JS wrapper is holding an XX megabyte DOM tree.
Attachments
WIP (14.43 KB, patch)
2011-03-02 10:20 PST, Vitaly Repeshko 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Vitaly Repeshko
Comment 1 2011-03-02 10:20:07 PST
Created attachment 84435 [details] WIP
Mikhail Naganov
Comment 2 2011-03-03 01:50:46 PST
Comment on attachment 84435 [details] WIP View in context: https://bugs.webkit.org/attachment.cgi?id=84435&action=review > Source/WebCore/dom/ContainerNode.cpp:691 > + child->estimateMemoryUsage(report); nit: indent
Antti Koivisto
Comment 3 2011-03-03 04:26:40 PST
Looks good. It would also be nice to classify the memory usage to broad categories (strings, DOM, etc). You could make addSelfSize a template function so you could avoid repeating sizeof() everywhere.
Ilya Tikhonovsky
Comment 4 2012-06-20 07:34:51 PDT
*** This bug has been marked as a duplicate of bug 89568 ***
Note You need to log in before you can comment on or make changes to this bug.