Summary: | Test results don't get uploaded if test-result-archive fails to delete the results directory | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | lforschler, mrowe, wsiegrist | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
URL: | http://build.webkit.org/builders/Windows%20XP%20Debug%20%28Tests%29/builds/25891/steps/archive-test-results/logs/stdio | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2011-03-02 08:30:55 PST
It looks like there was a websocket server process still holding onto the files that couldn't be deleted. I've filed bug 55583 to cover the fact that that process was sticking around. I still think we should fix this bug. Created attachment 85375 [details]
Ignore errors from files being held open when creating a test result archive
Comment on attachment 85375 [details]
Ignore errors from files being held open when creating a test result archive
r=me. It would be nice if we could somehow detect the stale files and clean them up (move them to a different directory perhaps?), but this is certainly a big improvement.
Committed r80748: <http://trac.webkit.org/changeset/80748> |