Bug 55581

Summary: Test results don't get uploaded if test-result-archive fails to delete the results directory
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: lforschler, mrowe, wsiegrist
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
URL: http://build.webkit.org/builders/Windows%20XP%20Debug%20%28Tests%29/builds/25891/steps/archive-test-results/logs/stdio
Attachments:
Description Flags
Ignore errors from files being held open when creating a test result archive mrowe: review+

Adam Roben (:aroben)
Reported 2011-03-02 08:30:55 PST
Test results don't get uploaded if test-result-archive fails to delete the results directory. Here's an example of this happening on apple-windows-13: http://build.webkit.org/builders/Windows%20XP%20Debug%20%28Tests%29/builds/25891/steps/archive-test-results/logs/stdio We should probably make the script just ignore this error.
Attachments
Ignore errors from files being held open when creating a test result archive (1.80 KB, patch)
2011-03-10 12:45 PST, Adam Roben (:aroben) 		mrowe: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-03-02 08:53:34 PST
It looks like there was a websocket server process still holding onto the files that couldn't be deleted. I've filed bug 55583 to cover the fact that that process was sticking around. I still think we should fix this bug.
Adam Roben (:aroben)
Comment 2 2011-03-10 12:45:16 PST
Created attachment 85375 [details] Ignore errors from files being held open when creating a test result archive
Mark Rowe (bdash)
Comment 3 2011-03-10 12:47:38 PST
Comment on attachment 85375 [details] Ignore errors from files being held open when creating a test result archive r=me. It would be nice if we could somehow detect the stale files and clean them up (move them to a different directory perhaps?), but this is certainly a big improvement.
Adam Roben (:aroben)
Comment 4 2011-03-10 12:58:02 PST
Committed r80748: <http://trac.webkit.org/changeset/80748>
Note You need to log in before you can comment on or make changes to this bug.