Bug 55566

Summary: V8 version of JavaString should obtain string from JNI in UTF-16 encoding
Product: WebKit Reporter: Steve Block <steveblock>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, jorlow, steveblock, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: Other   
Bug Depends on: 55567    
Bug Blocks:    
Attachments:
Description Flags
Patch none

Steve Block
Reported 2011-03-02 03:12:55 PST
Currently, the V8 version of JavaString obtains the string from JNI in modified UTF-8 encoding. This does not match the regular UTF-8 encoding. Instead, we should obtain the string from JNI in UTF-16 encoding and convert to UTF-8 using our own routines as required. This matches the behaviour of the JSC version of JavaString.
Attachments
Patch (2.69 KB, patch)
2011-03-02 12:58 PST, Steve Block 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Steve Block
Comment 1 2011-03-02 12:58:14 PST
Created attachment 84450 [details] Patch
Jeremy Orlow
Comment 2 2011-03-03 17:58:42 PST
Comment on attachment 84450 [details] Patch r=me
WebKit Commit Bot
Comment 3 2011-03-04 01:45:29 PST
Comment on attachment 84450 [details] Patch Clearing flags on attachment: 84450 Committed r80339: <http://trac.webkit.org/changeset/80339>
WebKit Commit Bot
Comment 4 2011-03-04 01:45:33 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2011-03-04 03:18:43 PST
http://trac.webkit.org/changeset/80339 might have broken GTK Linux 64-bit Debug The following tests are not passing: fast/dom/HTMLDocument/hasFocus.html fast/events/standalone-image-drag-to-editable.html fast/files/apply-blob-url-to-img.html inspector/timeline/timeline-network-resource.html
Note You need to log in before you can comment on or make changes to this bug.