Bug 55553 – When displaying the missing plug-in sheet, pass the 'pluginspage' attribute to the UI process.

• Component: New Bugs
• Status: RESOLVED FIXED

[Andy Estes]

When displaying the missing plug-in sheet, pass the 'pluginspage' attribute to the UI process.

[Andy Estes]

Created attachment 84371 [details]
Patch

[Andy Estes]

<rdar://problem/9057876>

[Darin Adler]

Comment on attachment 84371 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=84371&action=review

> Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:461
> +    m_page->send(Messages::WebPageProxy::MissingPluginButtonClicked(pluginElement->serviceType(), pluginElement->url(), pluginElement->getAttribute("pluginspage")));

For better performance, this should be:

    fastGetAttribute(pluginspageAttr);

And that might require exporting another symbol.

[Andy Estes]

(In reply to comment #3)
> (From update of attachment 84371 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84371&action=review
> 
> > Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:461
> > +    m_page->send(Messages::WebPageProxy::MissingPluginButtonClicked(pluginElement->serviceType(), pluginElement->url(), pluginElement->getAttribute("pluginspage")));
> 
> For better performance, this should be:
> 
>     fastGetAttribute(pluginspageAttr);
> 
> And that might require exporting another symbol.

Thanks for the review! Will do.

[Andy Estes]

Committed <http://trac.webkit.org/changeset/80297>.