Summary: | When displaying the missing plug-in sheet, pass the 'pluginspage' attribute to the UI process. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Andy Estes <aestes> | ||||
Component: | New Bugs | Assignee: | Andy Estes <aestes> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | Keywords: | InRadar | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Andy Estes
2011-03-01 22:54:37 PST
Created attachment 84371 [details]
Patch
Comment on attachment 84371 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84371&action=review > Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:461 > + m_page->send(Messages::WebPageProxy::MissingPluginButtonClicked(pluginElement->serviceType(), pluginElement->url(), pluginElement->getAttribute("pluginspage"))); For better performance, this should be: fastGetAttribute(pluginspageAttr); And that might require exporting another symbol. (In reply to comment #3) > (From update of attachment 84371 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=84371&action=review > > > Source/WebKit2/WebProcess/WebCoreSupport/WebChromeClient.cpp:461 > > + m_page->send(Messages::WebPageProxy::MissingPluginButtonClicked(pluginElement->serviceType(), pluginElement->url(), pluginElement->getAttribute("pluginspage"))); > > For better performance, this should be: > > fastGetAttribute(pluginspageAttr); > > And that might require exporting another symbol. Thanks for the review! Will do. Committed <http://trac.webkit.org/changeset/80297>. |