Bug 55538

Summary: Update webkit layout test expectations for Chromium for strict mode
Product: WebKit Reporter: mmaly
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ager, commit-queue, dglazkov, mmaly
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.6   
Attachments:
Description Flags
The patch for Webkit expectations for Chromium for newly implemented strict mode features.
none
Trying again, hopefully this time bots will succeed in unpacking the patch.
dglazkov: review+, commit-queue: commit-queue-
Adding test expectations for strict mode Chromium fixes. none

mmaly
Reported 2011-03-01 17:50:27 PST
As strict mode implementation progresses newly implemented features trigger failures because of obsolete test expectations. Please update: test_expectations.txt fast/js/mozilla/strict/15.3.5.1-expected.txt fast/js/mozilla/strict/15.10.7-expected.txt fast/js/mozilla/strict/15.5.5.1-expected.txt for Chromium test pass.
Attachments
The patch for Webkit expectations for Chromium for newly implemented strict mode features. (5.02 KB, text/plain)
2011-03-01 17:58 PST, mmaly 		no flags
Details
Trying again, hopefully this time bots will succeed in unpacking the patch. (5.01 KB, text/plain)
2011-03-01 18:23 PST, mmaly 		dglazkov: review+
commit-queue: commit-queue-
Details
Adding test expectations for strict mode Chromium fixes. (5.19 KB, patch)
2011-03-02 08:15 PST, mmaly 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
mmaly
Comment 1 2011-03-01 17:58:48 PST
Created attachment 84339 [details] The patch for Webkit expectations for Chromium for newly implemented strict mode features.
mmaly
Comment 2 2011-03-01 18:22:29 PST
Comment on attachment 84339 [details] The patch for Webkit expectations for Chromium for newly implemented strict mode features. Somehow the bots didn't like this patch.
mmaly
Comment 3 2011-03-01 18:23:21 PST
Created attachment 84345 [details] Trying again, hopefully this time bots will succeed in unpacking the patch.
mmaly
Comment 4 2011-03-01 18:27:04 PST
Ok, giving up. Something is out of ordinary with this patch that bots don't seem to like it ... hmm ... Hopefully someone in webkit land knows how to handle this. There should be nothing special about this patch.
Dimitri Glazkov (Google)
Comment 5 2011-03-01 18:35:05 PST
Comment on attachment 84345 [details] Trying again, hopefully this time bots will succeed in unpacking the patch. looks good.
WebKit Commit Bot
Comment 6 2011-03-01 22:06:07 PST
Comment on attachment 84345 [details] Trying again, hopefully this time bots will succeed in unpacking the patch. Rejecting attachment 84345 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: atform/chromium/test_expectations.txt (working copy) -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored patching file platform/chromium/fast/js/mozilla/strict/15.3.5.1-expected.txt patching file platform/chromium/fast/js/mozilla/strict/15.5.5.1-expected.txt patching file platform/chromium/fast/js/mozilla/strict/15.10.7-expected.txt Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/8076793
Mads Ager
Comment 7 2011-03-01 23:51:12 PST
Martin, it looks like this patch is relative to the LayoutTest directory and not the top WebKit directory. That could be what is causing this. Could you try with a patch relative to the root WebKit directory?
mmaly
Comment 8 2011-03-02 08:14:15 PST
Comment on attachment 84345 [details] Trying again, hopefully this time bots will succeed in unpacking the patch. Patch fails to unpack again. Trying one more time.
mmaly
Comment 9 2011-03-02 08:15:24 PST
Created attachment 84420 [details] Adding test expectations for strict mode Chromium fixes. Third time is a charm. Creating patch relative to WebKit root.
Dimitri Glazkov (Google)
Comment 10 2011-03-02 08:48:16 PST
Comment on attachment 84420 [details] Adding test expectations for strict mode Chromium fixes. Make it so.
WebKit Commit Bot
Comment 11 2011-03-02 09:11:30 PST
Comment on attachment 84420 [details] Adding test expectations for strict mode Chromium fixes. Clearing flags on attachment: 84420 Committed r80138: <http://trac.webkit.org/changeset/80138>
WebKit Commit Bot
Comment 12 2011-03-02 09:11:35 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.