| Summary: | Update webkit layout test expectations for Chromium for strict mode | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mmaly | ||||||||
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | ager, commit-queue, dglazkov, mmaly | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | OS X 10.6 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
mmaly
2011-03-01 17:50:27 PST
Created attachment 84339 [details]
The patch for Webkit expectations for Chromium for newly implemented strict mode features.
Comment on attachment 84339 [details]
The patch for Webkit expectations for Chromium for newly implemented strict mode features.
Somehow the bots didn't like this patch.
Created attachment 84345 [details]
Trying again, hopefully this time bots will succeed in unpacking the patch.
Ok, giving up. Something is out of ordinary with this patch that bots don't seem to like it ... hmm ... Hopefully someone in webkit land knows how to handle this. There should be nothing special about this patch. Comment on attachment 84345 [details]
Trying again, hopefully this time bots will succeed in unpacking the patch.
looks good.
Comment on attachment 84345 [details] Trying again, hopefully this time bots will succeed in unpacking the patch. Rejecting attachment 84345 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-8', 'apply-..." exit_code: 2 Last 500 characters of output: atform/chromium/test_expectations.txt (working copy) -------------------------- No file to patch. Skipping patch. 1 out of 1 hunk ignored patching file platform/chromium/fast/js/mozilla/strict/15.3.5.1-expected.txt patching file platform/chromium/fast/js/mozilla/strict/15.5.5.1-expected.txt patching file platform/chromium/fast/js/mozilla/strict/15.10.7-expected.txt Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'Dimitri Glazkov', u'--..." exit_code: 1 Full output: http://queues.webkit.org/results/8076793 Martin, it looks like this patch is relative to the LayoutTest directory and not the top WebKit directory. That could be what is causing this. Could you try with a patch relative to the root WebKit directory? Comment on attachment 84345 [details]
Trying again, hopefully this time bots will succeed in unpacking the patch.
Patch fails to unpack again. Trying one more time.
Created attachment 84420 [details]
Adding test expectations for strict mode Chromium fixes.
Third time is a charm. Creating patch relative to WebKit root.
Comment on attachment 84420 [details]
Adding test expectations for strict mode Chromium fixes.
Make it so.
Comment on attachment 84420 [details] Adding test expectations for strict mode Chromium fixes. Clearing flags on attachment: 84420 Committed r80138: <http://trac.webkit.org/changeset/80138> All reviewed patches have been landed. Closing bug. |