Summary: | compositing/video/video-background-color.html test does not produce correct output | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Victoria Kirst <vrk> | ||||||||
Component: | Tools / Tests | Assignee: | Ami Fischman <fischman> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | eric.carlson, fischman, rniwa, webkit.review.bot | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | PC | ||||||||||
OS: | OS X 10.5 | ||||||||||
Attachments: |
|
Description
Victoria Kirst
2011-03-01 15:28:47 PST
(In reply to comment #0) > The LayoutTest compositing/video/video-background-color.html says, "Top and bottom should > look the same." But the image provided is a gradient, and there does not appear to be a CSS > gradient on the video, so the two figures do not match. I'm not sure what this LayoutTest is > intending to test. There is a gradient in alpha-gradient-small.mov > There is a gradient in alpha-gradient-small.mov
Ah, there doesn't appear to be a gradient in .ogv :) Looks like a problem with our test video. Thanks, Eric! I can upload a different one later.
It looks like none of the video formats supported by chromium support encoded alpha in the video data, so I think this is going to have to be a SKIP WONTFIX in chromium's test_expectation. Created attachment 102974 [details]
Patch
Comment on attachment 102974 [details] Patch Rejecting attachment 102974 [details] from review queue. imasaki@chromium.org does not have reviewer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/committers.py. - If you do not have reviewer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have reviewer rights please correct the error in Tools/Scripts/webkitpy/common/config/committers.py by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your reviewer rights. Comment on attachment 102974 [details] Patch Rejecting attachment 102974 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=ec2-cq-02', '--port..." exit_code: 2 Last 500 characters of output: apply', u'--reviewer', u'David Levin', u'--force']" exit_code: 1 Parsed 2 diffs from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/chromium/test_expectations.txt Hunk #2 FAILED at 2655. 1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/chromium/test_expectations.txt.rej Failed to run "[u'/mnt/git/webkit-commit-queue/Tools/Scripts/svn-apply', u'--reviewer', u'David Levin', u'--force']" exit_code: 1 Full output: http://queues.webkit.org/results/9302662 Created attachment 102996 [details]
Patch
Created attachment 103081 [details]
Patch
Re-opening in hopes of CQ landing. ...and moving to assigned. Committed r92483: <http://trac.webkit.org/changeset/92483> Comment on attachment 103081 [details]
Patch
Removing cq+ and obsoleting patch since rniwa landed manually (thanks!)
|