Summary: | REGRESSION (r79925): Lots of plugins tests crashing in NetscapePlugin::initialize on Windows | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||
Component: | Plug-ins | Assignee: | Adam Roben (:aroben) <aroben> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, andersca, eric, kbalazs, webkit.review.bot | ||||
Priority: | P2 | Keywords: | InRadar, LayoutTestFailure, PlatformOnly, Regression | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Windows XP | ||||||
URL: | http://build.webkit.org/results/Windows%207%20Release%20(WebKit2%20Tests)/r80018%20(3580)/results.html | ||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2011-03-01 15:00:11 PST
Looks like PLUGIN_ARCHITECTURE(WIN) isn't true on Windows. Created attachment 84310 [details]
Make the PLUGIN_ARCHITECTURE() macro work with MSVC
Comment on attachment 84310 [details] Make the PLUGIN_ARCHITECTURE() macro work with MSVC View in context: https://bugs.webkit.org/attachment.cgi?id=84310&action=review > Source/WebKit2/Shared/Plugins/Netscape/NetscapePluginModule.cpp:36 > +#error Unknown platform Can this say "Unknown plug-in architecture" instead? Committed r80051: <http://trac.webkit.org/changeset/80051> Incorporated Anders's comment Committed r80053: <http://trac.webkit.org/changeset/80053> http://trac.webkit.org/changeset/80051 might have broken Qt Linux Release The following tests are not passing: fast/canvas/canvas-strokePath-gradient-shadow.html My fault. Thanks for the fix Adam. |