Bug 55513

Summary: REGRESSION (r79925): Lots of plugins tests crashing in NetscapePlugin::initialize on Windows
Product: WebKit Reporter: Adam Roben (:aroben) <aroben>
Component: Plug-insAssignee: Adam Roben (:aroben) <aroben>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andersca, eric, kbalazs, webkit.review.bot
Priority: P2 Keywords: InRadar, LayoutTestFailure, PlatformOnly, Regression
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
URL: http://build.webkit.org/results/Windows%207%20Release%20(WebKit2%20Tests)/r80018%20(3580)/results.html
Attachments:
Description Flags
Make the PLUGIN_ARCHITECTURE() macro work with MSVC andersca: review+

Adam Roben (:aroben)
Reported 2011-03-01 15:00:11 PST
Lots of plugins tests are crashing in NetscapePlugin::initialize on Windows. See the URL for crash logs. This seems to have started happening somewhat recently, though I'm not exactly sure when.
Attachments
Make the PLUGIN_ARCHITECTURE() macro work with MSVC (12.71 KB, patch)
2011-03-01 15:32 PST, Adam Roben (:aroben) 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Roben (:aroben)
Comment 1 2011-03-01 15:00:31 PST
<rdar://problem/9069189>
Adam Roben (:aroben)
Comment 2 2011-03-01 15:02:52 PST
Looks like PLUGIN_ARCHITECTURE(WIN) isn't true on Windows.
Adam Roben (:aroben)
Comment 3 2011-03-01 15:32:01 PST
Created attachment 84310 [details] Make the PLUGIN_ARCHITECTURE() macro work with MSVC
Anders Carlsson
Comment 4 2011-03-01 15:33:37 PST
Comment on attachment 84310 [details] Make the PLUGIN_ARCHITECTURE() macro work with MSVC View in context: https://bugs.webkit.org/attachment.cgi?id=84310&action=review > Source/WebKit2/Shared/Plugins/Netscape/NetscapePluginModule.cpp:36 > +#error Unknown platform Can this say "Unknown plug-in architecture" instead?
Adam Roben (:aroben)
Comment 5 2011-03-01 15:39:14 PST
Committed r80051: <http://trac.webkit.org/changeset/80051>
Adam Roben (:aroben)
Comment 6 2011-03-01 15:46:24 PST
Incorporated Anders's comment Committed r80053: <http://trac.webkit.org/changeset/80053>
WebKit Review Bot
Comment 7 2011-03-01 16:33:19 PST
http://trac.webkit.org/changeset/80051 might have broken Qt Linux Release The following tests are not passing: fast/canvas/canvas-strokePath-gradient-shadow.html
Balazs Kelemen
Comment 8 2011-03-02 00:58:11 PST
My fault. Thanks for the fix Adam.
Note You need to log in before you can comment on or make changes to this bug.