Summary: | [Qt][WK2] Loading an empty URL crashes | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||||||
Component: | WebKit2 | Assignee: | Benjamin Poulain <benjamin> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, kenneth, kling, sam, webkit.review.bot | ||||||||
Priority: | P3 | Keywords: | Qt, QtTriaged | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Benjamin Poulain
2011-03-01 13:29:36 PST
Created attachment 84290 [details]
Patch
Attachment 84290 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/API/qt/tests/qwkpage/tst_qwkpage.cpp:20: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 85817 [details]
Patch
As Andreas pointed out on IRC, null WKURLRef are actually a valid value in the WebKit 2 C APIs.
I changed the patch to take that into account. It happens that there is a method toWTFString() to do all the work for me :)
Attachment 85817 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/API/qt/tests/qwkpage/tst_qwkpage.cpp:20: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 85817 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=85817&action=review > Source/WebKit2/UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp:99 > + // That should not crash. > + m_view->show(); > + m_view->m_webView->load(QUrl()); > + QTest::qWait(50); > + > + m_view->m_webView->load(QUrl("")); > + QTest::qWait(50); Let's use the QWKPage::engineConnectionChanged() signal to find out if the web process crashed. This test would never fail, since the autotest process cruises along happily. Created attachment 85921 [details] Patch > Let's use the QWKPage::engineConnectionChanged() signal to find out if the web process crashed. > This test would never fail, since the autotest process cruises along happily. Good point, I did not realize crashing the WebProcess would not have side effects on the test. Patch updated. Attachment 85921 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/UIProcess/API/qt/tests/qwkpage/tst_qwkpage.cpp:20: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 1 in 6 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 85921 [details] Patch Clearing flags on attachment: 85921 Committed r81237: <http://trac.webkit.org/changeset/81237> All reviewed patches have been landed. Closing bug. |