Bug 55425

Summary: Teach JavaScriptCore GYP build about DEPTH
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 55018    
Attachments:
Description Flags
Patch none

Adam Barth
Reported 2011-02-28 16:39:35 PST
Teach JavaScriptCore GYP build about DEPTH
Attachments
Patch (4.30 KB, patch)
2011-02-28 16:40 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-02-28 16:40:47 PST
Created attachment 84150 [details] Patch
Eric Seidel (no email)
Comment 2 2011-02-28 23:55:23 PST
Comment on attachment 84150 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=84150&action=review > Source/JavaScriptCore/gyp/JavaScriptCore.gyp:27 > + '<(DEPTH)', # Some paths in API include JavaScriptCore/ > + '<(DEPTH)/JavaScriptCore', > + '<(DEPTH)/JavaScriptCore/ForwardingHeaders', > + '<(DEPTH)/JavaScriptCore/API', > + '<(DEPTH)/JavaScriptCore/assembler', > + '<(DEPTH)/JavaScriptCore/collector/handles', > + '<(DEPTH)/JavaScriptCore/bytecode', > + '<(DEPTH)/JavaScriptCore/bytecompiler', > + '<(DEPTH)/JavaScriptCore/debugger', > + '<(DEPTH)/JavaScriptCore/icu', > + '<(DEPTH)/JavaScriptCore/interpreter', > + '<(DEPTH)/JavaScriptCore/jit', > + '<(DEPTH)/JavaScriptCore/parser', > + '<(DEPTH)/JavaScriptCore/profiler', > + '<(DEPTH)/JavaScriptCore/runtime', > + '<(DEPTH)/JavaScriptCore/wtf', > + '<(DEPTH)/JavaScriptCore/wtf/unicode', This seems annoyingly verbose. Would be nice to have an INCLUDE_ROOT feature for gyp. :)
Adam Barth
Comment 3 2011-03-01 00:06:58 PST
We can create an INCLUDE_ROOT variable pretty easily.
Eric Seidel (no email)
Comment 4 2011-03-01 00:12:02 PST
I mean so that we don't have to use DEPTH for every include line.
WebKit Commit Bot
Comment 5 2011-03-01 00:14:46 PST
Comment on attachment 84150 [details] Patch Clearing flags on attachment: 84150 Committed r79974: <http://trac.webkit.org/changeset/79974>
WebKit Commit Bot
Comment 6 2011-03-01 00:14:51 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.