Bug 55412 – Frequent crashes in CFURLCache code on Snow Leopard

• Component: WebKit2
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

We're passing a wrong path when creating an NSURLCache, so it can't initialize an SQL database, and misbehaves.

<rdar://problem/9063922>

[Alexey Proskuryakov]

Created attachment 84125 [details]
proposed fix

Comment on attachment 84125 [details]
proposed fix

View in context: https://bugs.webkit.org/attachment.cgi?id=84125&action=review

> Source/WebKit2/ChangeLog:18
> +        like have liked trailing slash).

extra “like”

> Source/WebKit2/Shared/WebProcessCreationParameters.h:83
> +    // FIXME: These should not be merged with CFURLCache counterparts below.

not?

> Source/WebKit2/UIProcess/mac/WebContextMac.mm:85
> +    ASSERT(parameters.nsURLCachePath.data()[strlen(parameters.nsURLCachePath.data()) - 1] != '/'); // Necessary for NSURLCache to find the cache file.

Should we assert that strlen(…) is > 0 first?

> Source/WebKit2/UIProcess/win/WebContextWin.cpp:68
> +    if (parameters.cfURLCachePath[parameters.cfURLCachePath.length() - 1] == '/')

and here

[Alexey Proskuryakov]

Fixed in http://trac.webkit.org/changeset/79927.

Note that there is some controversy around whether it's really OK for CString length to not match strlen. But we already use strlen with -[NSFileManager stringWithFileSystemRepresentation:length:] elsewhere.