| Summary: | [Qt][WK2] Add a way to test the WebKit 2 APIs | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Benjamin Poulain <benjamin> | ||||
| Component: | WebKit2 | Assignee: | Benjamin Poulain <benjamin> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, abecsi, commit-queue, eric, kbalazs, kenneth, webkit.review.bot | ||||
| Priority: | P3 | Keywords: | Qt, QtTriaged | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | All | ||||||
| Attachments: |
|
||||||
|
Description
Benjamin Poulain
2011-02-28 13:52:12 PST
Created attachment 84114 [details]
Patch
Some style errors expected: util.h and the headers of the test.
I copied util.h from the tests of WebKit 1.
Suggestion very welcome to make the improve the way the test are built (and the place where the tests should be).
Attachment 84114 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'ChangeLog', u'Source/WebKit.pri', u'Source..." exit_code: 1
Source/WebKit2/UIProcess/API/qt/tests/util.h:55: __step is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebKit2/UIProcess/API/qt/tests/util.h:56: __timeout is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebKit2/UIProcess/API/qt/tests/util.h:60: Missing spaces around += [whitespace/operators] [3]
Source/WebKit2/UIProcess/API/qt/tests/util.h:60: __i is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebKit2/UIProcess/API/qt/tests/util.h:64: Missing space before ( in while( [whitespace/parens] [5]
Source/WebKit2/UIProcess/API/qt/tests/util.h:69: __step is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebKit2/UIProcess/API/qt/tests/util.h:70: __timeout is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebKit2/UIProcess/API/qt/tests/util.h:74: Missing spaces around += [whitespace/operators] [3]
Source/WebKit2/UIProcess/API/qt/tests/util.h:74: __i is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Source/WebKit2/UIProcess/API/qt/tests/util.h:78: Missing space before ( in while( [whitespace/parens] [5]
Source/WebKit2/UIProcess/API/qt/tests/qgraphicswkview/tst_qgraphicswkview.cpp:20: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 11 in 10 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 84114 [details]
Patch
Great start!
The commit-queue encountered the following flaky tests while processing attachment 84114 [details]: fast/lists/inlineBoxWrapperNullCheck.html bug 55428 (author: bdakin@apple.com) The commit-queue is continuing to process your patch. Comment on attachment 84114 [details] Patch Clearing flags on attachment: 84114 Committed r79945: <http://trac.webkit.org/changeset/79945> All reviewed patches have been landed. Closing bug. http://trac.webkit.org/changeset/79945 might have broken Qt Linux Release The following tests are not passing: fast/events/tabindex-focus-blur-all.html fast/frames/iframe-plugin-load-remove-document-crash.html fast/frames/sandboxed-iframe-attribute-parsing.html fast/layers/clip-rects-transformed.html fast/replaced/object-with-non-empty-classid-triggers-fallback.html plugins/createScriptableObject-before-start.html plugins/destroy-on-setwindow.html plugins/destroy-plugin-from-callback.html plugins/destroy-stream-twice.html plugins/document-open.html plugins/evaluate-js-after-removing-plugin-element.html plugins/get-file-url.html plugins/get-url-that-the-resource-load-delegate-will-disallow.html plugins/get-url-with-javascript-destroying-plugin.html plugins/geturl-replace-query.html plugins/geturlnotify-during-document-teardown.html plugins/instance-available-before-stylesheets-loaded-object.html plugins/invalid-mime-with-valid-extension-shows-missing-plugin.html plugins/js-from-destroy.html |