Bug 55355

Summary: TextIterator should not be a friend of RenderTextControl
Product: WebKit Reporter: Roland Steiner <rolandsteiner>
Component: Layout and RenderingAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, dominicc, morrita
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 54179    
Attachments:
Description Flags
Patch none

Description Roland Steiner 2011-02-28 00:13:08 PST 
TextIterator should use interface methods rather than being a friend.
Comment 1 Roland Steiner 2011-02-28 00:18:31 PST 
Created attachment 84024 [details]
Patch

Simple patch: remove need for friend-clause by making innerTextElement() public. Even after the general new-shadow-DOM refactoring there will be a common inner text element, so the accessor will likely stay around. We might want to restrict visibility of the shadow DOM from RenderTextControl, but this is for yet another (larger) refactoring.
Comment 2 Kent Tamura 2011-02-28 00:23:10 PST 
Comment on attachment 84024 [details]
Patch

looks good.
Comment 3 WebKit Commit Bot 2011-02-28 00:45:40 PST 
Comment on attachment 84024 [details]
Patch

Clearing flags on attachment: 84024

Committed r79845: <http://trac.webkit.org/changeset/79845>
Comment 4 WebKit Commit Bot 2011-02-28 00:45:45 PST 
All reviewed patches have been landed.  Closing bug.