Bug 55332

Summary: Use String instead of CString as return value of openTemporaryFile
Product: WebKit Reporter: Patrick R. Gansterer <paroga>
Component: New BugsAssignee: Patrick R. Gansterer <paroga>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, andersca, buildbot, commit-queue, darin, eric, webkit-ews, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Patrick R. Gansterer
Reported 2011-02-27 14:24:01 PST
Use String instead of CString as return value of openTemporaryFile
Attachments
Patch (19.13 KB, patch)
2011-02-27 14:28 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (19.37 KB, patch)
2011-02-27 15:15 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Patch (20.17 KB, patch)
2011-02-27 17:08 PST, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2011-02-27 14:28:22 PST
Created attachment 83995 [details] Patch
Early Warning System Bot
Comment 2 2011-02-27 14:45:51 PST
Attachment 83995 [details] did not build on qt: Build output: http://queues.webkit.org/results/8075093
Build Bot
Comment 3 2011-02-27 14:46:34 PST
Attachment 83995 [details] did not build on win: Build output: http://queues.webkit.org/results/8023029
WebKit Review Bot
Comment 4 2011-02-27 15:10:28 PST
Attachment 83995 [details] did not build on mac: Build output: http://queues.webkit.org/results/8070199
Patrick R. Gansterer
Comment 5 2011-02-27 15:15:55 PST
Created attachment 83997 [details] Patch Fixed EWS failures
WebKit Review Bot
Comment 6 2011-02-27 15:24:21 PST
Attachment 83997 [details] did not build on mac: Build output: http://queues.webkit.org/results/8076073
Early Warning System Bot
Comment 7 2011-02-27 15:48:25 PST
Attachment 83997 [details] did not build on qt: Build output: http://queues.webkit.org/results/8071163
Patrick R. Gansterer
Comment 8 2011-02-27 17:08:44 PST
Created attachment 84005 [details] Patch
WebKit Commit Bot
Comment 9 2011-03-28 10:16:22 PDT
Comment on attachment 84005 [details] Patch Rejecting attachment 84005 [details] from commit-queue. Failed to run "['./Tools/Scripts/webkit-patch', '--status-host=queues.webkit.org', '--bot-id=cr-jail-4', 'apply-..." exit_code: 1 Last 500 characters of output: autoinstalled/mechanize/_urllib2_fork.py", line 332, in _call_chain result = func(*args) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1170, in https_open return self.do_open(conn_factory, req) File "/mnt/git/webkit-commit-queue/Tools/Scripts/webkitpy/thirdparty/autoinstalled/mechanize/_urllib2_fork.py", line 1118, in do_open raise URLError(err) urllib2.URLError: <urlopen error [Errno 60] Operation timed out> Full output: http://queues.webkit.org/results/8279048
WebKit Commit Bot
Comment 10 2011-03-28 22:29:37 PDT
Comment on attachment 84005 [details] Patch Clearing flags on attachment: 84005 Committed r82193: <http://trac.webkit.org/changeset/82193>
WebKit Commit Bot
Comment 11 2011-03-28 22:29:43 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 12 2011-03-28 22:47:37 PDT
http://trac.webkit.org/changeset/82193 might have broken WinCE Release (Build)
Note You need to log in before you can comment on or make changes to this bug.