Bug 5532

Summary: Clean up bidi.cpp
Product: WebKit Reporter: mitz
Component: Layout and RenderingAssignee: Dave Hyatt <hyatt>
Status: VERIFIED FIXED    
Severity: Minor    
Priority: P3    
Version: 420+   
Hardware: Mac   
OS: OS X 10.4   
Bug Depends on:    
Bug Blocks: 5172    
Attachments:
Description Flags
Cleanup patch darin: review+

mitz
Reported 2005-10-28 07:39:41 PDT
Clean up WebCore/khtml/rendering/bidi.cpp to follow the WebKit coding style guidelines. Also change the dir and adjustEmbedding file statics into BidiState members (this could help with bug 5172) and remove some redundancy from bidiReorderLine().
Attachments
Cleanup patch (82.40 KB, patch)
2005-10-28 07:41 PDT, mitz 		darin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2005-10-28 07:41:38 PDT
Created attachment 4508 [details] Cleanup patch
mitz
Comment 2 2005-10-28 07:43:02 PDT
Comment on attachment 4508 [details] Cleanup patch I verified that all layout tests pass (except one that fails regardless of this patch).
Darin Adler
Comment 3 2005-10-28 10:43:29 PDT
Comment on attachment 4508 [details] Cleanup patch r=me
Dave Hyatt
Comment 4 2005-11-03 13:33:53 PST
I'll handle merging this since I'm doing some other cleanup.
Dave Hyatt
Comment 5 2005-11-03 15:52:42 PST
Landed with some edits. See Changelog.
mitz
Comment 6 2005-11-04 00:14:39 PST
Hmm... my bidiReorderLine() changes weren't committed. I guess I'll just stick them together with the patch for bug 5172. Also, the patch eliminated most tabs from the source, but these changes weren't committed either, so the tabs stay.
Note You need to log in before you can comment on or make changes to this bug.