Bug 55312

Summary: [Chromium] Uninitialized variable m_dumpAccessibilityNotifications
Product: WebKit Reporter: Dominic Mazzoni <dmazzoni>
Component: AccessibilityAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, dglazkov, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Attachments:
Description Flags
Initialize var in constructor
none
Initialize var in constructor (this time without typo) none

Dominic Mazzoni
Reported 2011-02-26 16:49:18 PST
Recently Chromium valgrind layout bots have been failing with a read-uninitialized-memory issue. it looks like m_dumpAccessibilityNotifications is never initialized in the constructor. However, the CL which introduced this is a few months old, so I'm unsure why behavior changed. First failure was here: http://build.chromium.org/p/chromium.memory/builders/Webkit%20Linux%20%28valgrind%20layout%29/builds/5521
Attachments
Initialize var in constructor (1.19 KB, patch)
2011-02-26 16:54 PST, Dominic Mazzoni 		no flags
DetailsFormatted DiffDiff
Initialize var in constructor (this time without typo) (1.19 KB, patch)
2011-02-26 17:10 PST, Dominic Mazzoni 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dominic Mazzoni
Comment 1 2011-02-26 16:54:28 PST
Created attachment 83957 [details] Initialize var in constructor
WebKit Review Bot
Comment 2 2011-02-26 16:58:00 PST
Attachment 83957 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8043969
Dominic Mazzoni
Comment 3 2011-02-26 17:10:19 PST
Created attachment 83958 [details] Initialize var in constructor (this time without typo)
WebKit Commit Bot
Comment 4 2011-02-26 18:46:13 PST
Comment on attachment 83958 [details] Initialize var in constructor (this time without typo) Clearing flags on attachment: 83958 Committed r79813: <http://trac.webkit.org/changeset/79813>
WebKit Commit Bot
Comment 5 2011-02-26 18:46:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.