Bug 55284

Summary:

DrawingArea should not be reference counted

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, webkit-ews, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	oliver: review+

Anders Carlsson

Reported 2011-02-25 18:19:05 PST

DrawingArea should not be reference counted

Attachments
Patch (27.18 KB, patch) 2011-02-25 18:20 PST, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (28.41 KB, patch) 2011-02-26 09:45 PST, Anders Carlsson	no flags	Details Formatted Diff Diff
Patch (28.40 KB, patch) 2011-02-26 10:35 PST, Anders Carlsson	oliver: review+	Details Formatted Diff Diff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.

Anders Carlsson

Comment 1 2011-02-25 18:20:26 PST

Created attachment 83913 [details] Patch

WebKit Review Bot

Comment 2 2011-02-25 18:23:08 PST

Attachment 83913 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:47: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebKit2/UIProcess/DrawingAreaProxy.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebKit2/Shared/DrawingAreaInfo.h:26: #ifndef header guard has wrong style, please use: WTF_DrawingAreaInfo_h [build/header_guard] [5] Source/WebKit2/WebProcess/WebPage/DrawingArea.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 4 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.

Build Bot

Comment 3 2011-02-25 19:10:17 PST

Attachment 83913 [details] did not build on win: Build output: http://queues.webkit.org/results/8044547

Early Warning System Bot

Comment 4 2011-02-25 20:17:03 PST

Attachment 83913 [details] did not build on qt: Build output: http://queues.webkit.org/results/8035535

Anders Carlsson

Comment 5 2011-02-26 09:45:36 PST

Created attachment 83944 [details] Patch

WebKit Review Bot

Comment 6 2011-02-26 09:46:46 PST

Attachment 83944 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:47: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebKit2/UIProcess/DrawingAreaProxy.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebKit2/Shared/DrawingAreaInfo.h:26: #ifndef header guard has wrong style, please use: WTF_DrawingAreaInfo_h [build/header_guard] [5] Source/WebKit2/UIProcess/ChunkedUpdateDrawingAreaProxy.h:34: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/WebProcess/WebPage/DrawingArea.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 5 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Early Warning System Bot

Comment 7 2011-02-26 10:18:50 PST

Attachment 83944 [details] did not build on qt: Build output: http://queues.webkit.org/results/8045009

Anders Carlsson

Comment 8 2011-02-26 10:35:54 PST

Created attachment 83945 [details] Patch

WebKit Review Bot

Comment 9 2011-02-26 10:38:15 PST

Attachment 83945 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1 Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:47: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4] Source/WebKit2/UIProcess/DrawingAreaProxy.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4] Source/WebKit2/Shared/DrawingAreaInfo.h:26: #ifndef header guard has wrong style, please use: WTF_DrawingAreaInfo_h [build/header_guard] [5] Source/WebKit2/UIProcess/ChunkedUpdateDrawingAreaProxy.h:34: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit2/WebProcess/WebPage/DrawingArea.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 5 in 23 files If any of these errors are false positives, please file a bug against check-webkit-style.

Anders Carlsson

Comment 10 2011-02-26 11:10:45 PST

Committed r79803: <http://trac.webkit.org/changeset/79803>

Note You need to log in before you can comment on or make changes to this bug.