| Summary: | DrawingArea should not be reference counted | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | buildbot, webkit-ews, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Other | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Anders Carlsson
2011-02-25 18:19:05 PST
Created attachment 83913 [details]
Patch
Attachment 83913 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:47: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
Source/WebKit2/UIProcess/DrawingAreaProxy.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebKit2/Shared/DrawingAreaInfo.h:26: #ifndef header guard has wrong style, please use: WTF_DrawingAreaInfo_h [build/header_guard] [5]
Source/WebKit2/WebProcess/WebPage/DrawingArea.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 4 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 83913 [details] did not build on win: Build output: http://queues.webkit.org/results/8044547 Attachment 83913 [details] did not build on qt: Build output: http://queues.webkit.org/results/8035535 Created attachment 83944 [details]
Patch
Attachment 83944 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:47: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
Source/WebKit2/UIProcess/DrawingAreaProxy.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebKit2/Shared/DrawingAreaInfo.h:26: #ifndef header guard has wrong style, please use: WTF_DrawingAreaInfo_h [build/header_guard] [5]
Source/WebKit2/UIProcess/ChunkedUpdateDrawingAreaProxy.h:34: Alphabetical sorting problem. [build/include_order] [4]
Source/WebKit2/WebProcess/WebPage/DrawingArea.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 5 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Attachment 83944 [details] did not build on qt: Build output: http://queues.webkit.org/results/8045009 Created attachment 83945 [details]
Patch
Attachment 83945 [details] did not pass style-queue:
Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebKit2/ChangeLog', u'Source/WebKit..." exit_code: 1
Source/WebKit2/WebProcess/WebPage/DrawingArea.cpp:47: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
Source/WebKit2/UIProcess/DrawingAreaProxy.h:41: Code inside a namespace should not be indented. [whitespace/indent] [4]
Source/WebKit2/Shared/DrawingAreaInfo.h:26: #ifndef header guard has wrong style, please use: WTF_DrawingAreaInfo_h [build/header_guard] [5]
Source/WebKit2/UIProcess/ChunkedUpdateDrawingAreaProxy.h:34: Alphabetical sorting problem. [build/include_order] [4]
Source/WebKit2/WebProcess/WebPage/DrawingArea.h:35: Code inside a namespace should not be indented. [whitespace/indent] [4]
Total errors found: 5 in 23 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Committed r79803: <http://trac.webkit.org/changeset/79803> |