Bug 55283

Summary: Make ScopeChainNode GC allocated
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: buildbot, dglazkov, gustavo.noronha, gustavo, ossy, webkit-ews, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch barraclough: review+

Oliver Hunt
Reported 2011-02-25 18:11:05 PST
Make ScopeChainNode GC allocated
Attachments
Patch (90.71 KB, patch)
2011-02-25 18:16 PST, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (97.00 KB, patch)
2011-02-28 12:09 PST, Oliver Hunt 		barraclough: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-02-25 18:16:38 PST
Created attachment 83911 [details] Patch
Early Warning System Bot
Comment 2 2011-02-25 19:40:09 PST
Attachment 83911 [details] did not build on qt: Build output: http://queues.webkit.org/results/8043579
Build Bot
Comment 3 2011-02-25 19:52:58 PST
Attachment 83911 [details] did not build on win: Build output: http://queues.webkit.org/results/8031574
Build Bot
Comment 4 2011-02-25 20:47:33 PST
Attachment 83911 [details] did not build on win: Build output: http://queues.webkit.org/results/8043603
Collabora GTK+ EWS bot
Comment 5 2011-02-25 20:51:33 PST
Attachment 83911 [details] did not build on gtk: Build output: http://queues.webkit.org/results/8035544
WebKit Review Bot
Comment 6 2011-02-25 23:16:44 PST
Attachment 83911 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8019600
Gavin Barraclough
Comment 7 2011-02-25 23:37:16 PST
Comment on attachment 83911 [details] Patch Per our discussion I suggest making scope chain an object so that it can hold properties in anonymous slots, and do away with custom marking (also, function should also be holding scope chain in an anonymous slot now). As such I'm going to r- for the time being. Hope this sounds right to you, feel free to argue we should land this as a cell for now if you thing this is a useful stepping stone & I'll re-review.
WebKit Review Bot
Comment 8 2011-02-26 13:37:42 PST
Attachment 83911 [details] did not build on chromium: Build output: http://queues.webkit.org/results/8031878
Oliver Hunt
Comment 9 2011-02-28 12:09:10 PST
Created attachment 84092 [details] Patch
Gavin Barraclough
Comment 10 2011-02-28 12:44:27 PST
Comment on attachment 84092 [details] Patch Okay, having function have different types of reference to its global object & scope is badness, but I understand that we'll revisit this.
Build Bot
Comment 11 2011-02-28 12:54:01 PST
Attachment 84092 [details] did not build on win: Build output: http://queues.webkit.org/results/8073418
Early Warning System Bot
Comment 12 2011-02-28 12:59:02 PST
Attachment 84092 [details] did not build on qt: Build output: http://queues.webkit.org/results/8073420
Oliver Hunt
Comment 13 2011-02-28 13:05:48 PST
Committed r79904: <http://trac.webkit.org/changeset/79904>
Collabora GTK+ EWS bot
Comment 14 2011-02-28 13:19:58 PST
Attachment 84092 [details] did not build on gtk: Build output: http://queues.webkit.org/results/8077151
Csaba Osztrogonác
Comment 15 2011-02-28 13:54:53 PST
(In reply to comment #12) > Attachment 84092 [details] did not build on qt: > Build output: http://queues.webkit.org/results/8073420 Qt buildfix landed in http://trac.webkit.org/changeset/79916 (https://bugs.webkit.org/show_bug.cgi?id=55407)
Note You need to log in before you can comment on or make changes to this bug.