Bug 55272

Summary: Add style guidelines about comments from the unwritten rules email.
Product: WebKit Reporter: David Levin <levin>
Component: WebKit WebsiteAssignee: David Levin <levin>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, darin, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 55253, 55271    
Attachments:
Description Flags
Patch none

David Levin
Reported 2011-02-25 15:44:18 PST
See https://lists.webkit.org/pipermail/webkit-dev/2009-September/009807.html (but be careful about the replies and the last changes done).
Attachments
Patch (2.30 KB, patch)
2011-02-25 15:54 PST, David Levin 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
David Levin
Comment 1 2011-02-25 15:49:51 PST
These changes address this part of the email: Usually, comments should look like sentences by beginning with a capital and ending with a period (punctation). One exception may be end of line comments like this "if (x == y) // false for NaN".There should be a *single* space after punctation and before the next sentence. There should only be a single space before end of line comments. Use FIXME: to denote items that need to be addressed in the future.
David Levin
Comment 2 2011-02-25 15:54:52 PST
Created attachment 83894 [details] Patch
WebKit Commit Bot
Comment 3 2011-02-26 06:45:26 PST
Comment on attachment 83894 [details] Patch Clearing flags on attachment: 83894 Committed r79785: <http://trac.webkit.org/changeset/79785>
WebKit Commit Bot
Comment 4 2011-02-26 06:45:31 PST
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 5 2011-02-27 09:01:49 PST
http://trac.webkit.org/changeset/79785 might have broken GTK Linux 32-bit Debug
Note You need to log in before you can comment on or make changes to this bug.