| Summary: | [Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Yi Shen <max.hong.shen> | ||||||
| Component: | Media | Assignee: | Yi Shen <max.hong.shen> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ademar, commit-queue, nancy.piedra, vestbo | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | OS X 10.5 | ||||||||
| Attachments: |
|
||||||||
|
Description
Yi Shen
2011-02-25 13:06:03 PST
Created attachment 83865 [details]
first try
Comment on attachment 83865 [details] first try View in context: https://bugs.webkit.org/attachment.cgi?id=83865&action=review > Source/WebCore/ChangeLog:8 > + Need to involk a call back function to notify the HTMLMediaElement s/involk/invoke/ s/call back/callback/ > Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:243 > + // Don't send PlaybackChanged notification for pre-roll Sentence style for comments (period at end missing.) :) > Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.h:160 > + bool m_ignorePlaybackChanged; Not a fan of this name, m_suppressNextPlaybackChanged perhaps? The fact that it only affects the next state change and then goes back to normal should be reflected somehow. Created attachment 83949 [details]
updated with Kling's suggestion
Thanks Kling :)
Comment on attachment 83949 [details]
updated with Kling's suggestion
r=me
Comment on attachment 83949 [details] updated with Kling's suggestion Clearing flags on attachment: 83949 Committed r79809: <http://trac.webkit.org/changeset/79809> All reviewed patches have been landed. Closing bug. Revision r79809 cherry-picked into qtwebkit-2.1.x with commit ac25b02 <http://gitorious.org/webkit/qtwebkit/commit/ac25b02> |