Bug 55252

Summary:

[Qt] Notify HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed

Product:

WebKit

Reporter:

Yi Shen <max.hong.shen>

Component:

Media

Assignee:

Yi Shen <max.hong.shen>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ademar, commit-queue, nancy.piedra, vestbo

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
first try	kling: review-
updated with Kling's suggestion	none

Yi Shen

Reported 2011-02-25 13:06:03 PST

Need to involk the call back function to notify the HTMLMediaElement when MediaPlayerPrivateQt's playback state gets changed.

Attachments
first try (2.86 KB, patch) 2011-02-25 13:18 PST, Yi Shen	kling: review-	Details Formatted Diff Diff
updated with Kling's suggestion (2.89 KB, patch) 2011-02-26 12:49 PST, Yi Shen	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Yi Shen

Comment 1 2011-02-25 13:18:18 PST

Created attachment 83865 [details] first try

Andreas Kling

Comment 2 2011-02-26 05:39:30 PST

Comment on attachment 83865 [details] first try View in context: https://bugs.webkit.org/attachment.cgi?id=83865&action=review > Source/WebCore/ChangeLog:8 > + Need to involk a call back function to notify the HTMLMediaElement s/involk/invoke/ s/call back/callback/ > Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.cpp:243 > + // Don't send PlaybackChanged notification for pre-roll Sentence style for comments (period at end missing.) :) > Source/WebCore/platform/graphics/qt/MediaPlayerPrivateQt.h:160 > + bool m_ignorePlaybackChanged; Not a fan of this name, m_suppressNextPlaybackChanged perhaps? The fact that it only affects the next state change and then goes back to normal should be reflected somehow.

Yi Shen

Comment 3 2011-02-26 12:49:45 PST

Created attachment 83949 [details] updated with Kling's suggestion Thanks Kling :)

Andreas Kling

Comment 4 2011-02-26 12:51:01 PST

Comment on attachment 83949 [details] updated with Kling's suggestion r=me

WebKit Commit Bot

Comment 5 2011-02-26 14:38:59 PST

Comment on attachment 83949 [details] updated with Kling's suggestion Clearing flags on attachment: 83949 Committed r79809: <http://trac.webkit.org/changeset/79809>

WebKit Commit Bot

Comment 6 2011-02-26 14:39:04 PST

All reviewed patches have been landed. Closing bug.

Ademar Reis

Comment 7 2011-02-28 14:04:35 PST

Revision r79809 cherry-picked into qtwebkit-2.1.x with commit ac25b02 <http://gitorious.org/webkit/qtwebkit/commit/ac25b02>

Note You need to log in before you can comment on or make changes to this bug.