Bug 55238 – Web Inspector: Resizing columns in the network panel is weird

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Matt Lilek]

Resizing the columns in the Network panel is weird.  Resizing a column only changes the amount of space between the columns on either side of the resizer instead of adjusting the whole tableview (the behavior of native TableViews on OS X).

For example, this makes is really hard to resize the Name column to see the full names of long resources.

I don't remember if this is how tableviews behave on Windows and don't have a machine handy to test, but we should match the host platform's behavior if that's the case.

Created attachment 93971 [details]
Patch

Includes resizing methods: nearest, last and first. Native NSTableView also has sequential an reverse sequential(that probably have the best effect) but adding those would mean adding minimum and maximum width ranges to columns instead of single fixed values.

[WebKit Review Bot]

Attachment 93971 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:4:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:9:  Line contains tab character.  [whitespace/tab] [5]
Source/WebCore/ChangeLog:10:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 93973 [details]
Patch

[WebKit Review Bot]

Attachment 93973 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCor..." exit_code: 1

Source/WebCore/ChangeLog:4:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 1 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Created attachment 93976 [details]
Pathc

[Pavel Feldman]

Comment on attachment 93976 [details]
Pathc

View in context: https://bugs.webkit.org/attachment.cgi?id=93976&action=review

There is a series of style nits, but otherwise looks good. Thanks for fixing this!

> Source/WebCore/inspector/front-end/DataGrid.js:927
> +        if (typeof this._resizeMethod==="undefined")

Nit: this should be:

typeof this._resizeMethod === "undefined"

> Source/WebCore/inspector/front-end/DataGrid.js:965
> +        if(this.resizeMethod==WebInspector.DataGrid.ResizeMethod.Last)

Spaces around == and before ( as well.

> Source/WebCore/inspector/front-end/DataGrid.js:966
> +        {

Style for if is
if (foo === bar) {
...
}

> Source/WebCore/inspector/front-end/DataGrid.js:969
> +        else if(this.resizeMethod==WebInspector.DataGrid.ResizeMethod.First)

ditto

> Source/WebCore/inspector/front-end/DataGrid.js:971
> +            leftEdgeOfPreviousColumn+=firstRowCells[leftCellIndex].offsetWidth - firstRowCells[0].offsetWidth;

Spaces around += are missing.

> Source/WebCore/inspector/front-end/DataGrid.js:1011
> +    Nearest:    'nearest',

No need to align values into a column.
Please use " instead of '

Created attachment 94071 [details]
Patch with style fixes

[Pavel Feldman]

Comment on attachment 94071 [details]
Patch with style fixes

View in context: https://bugs.webkit.org/attachment.cgi?id=94071&action=review

It looks good now, thanks. One nit you don't have to fix since it is minor + would require re-review. I am marking this change as cq+ which means it'll land automatically.

> Source/WebCore/inspector/front-end/DataGrid.js:965
> +        if (this.resizeMethod == WebInspector.DataGrid.ResizeMethod.Last) {

Nit: single liners do not need {}

[WebKit Commit Bot]

Comment on attachment 94071 [details]
Patch with style fixes

Clearing flags on attachment: 94071

Committed r86855: <http://trac.webkit.org/changeset/86855>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.