Bug 55216

Summary:

jsc::bindings::convertValueToNPVariant sometimes fail to find the root object

Product:

WebKit

Reporter:

Kristian Monsen <kristianm>

Component:

WebCore JavaScript

Assignee:

Nobody <webkit-unassigned>

Status:

UNCONFIRMED

Severity:

Normal

CC:

andersca, ap, ggaren

Priority:

Version:

528+ (Nightly build)

Hardware:

Android

OS:

Android

Attachments:

Description	Flags
Proposed patch	eric: review-

Kristian Monsen

Reported 2011-02-25 07:01:09 PST

jsc::bindings::convertValueToNPVariant sometimes fail to find the root object, it should use exec->lexicalGlobalObject instead of exec->dynamicGlobalObject.

Attachments
Proposed patch (1.35 KB, patch) 2011-02-25 07:04 PST, Kristian Monsen	eric: review-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Kristian Monsen

Comment 1 2011-02-25 07:04:14 PST

Created attachment 83804 [details] Proposed patch

Kristian Monsen

Comment 2 2011-02-25 07:39:00 PST

I am not an expert in this area as we mostly do not use JSC, but it looks to me that we should always use lexicalGlobalObject() and not dynamicGlobalObject. The major reason for the bug/patch is to get some input on if this is a good idea or not. It fixes a bug for us, but as I said I am not very familiar with the code so it might break other things.

Alexey Proskuryakov

Comment 3 2011-02-25 11:27:09 PST

See also: bug 41651.

Geoffrey Garen

Comment 4 2011-02-28 12:01:08 PST

This approach seems right to me, but it's hard to tell for sure without a test case demonstrating the change in behavior.

Eric Seidel (no email)

Comment 5 2011-04-28 11:38:23 PDT

Comment on attachment 83804 [details] Proposed patch Seems this is a change in functionality an needs testing. What bindings are affected by this?

Note You need to log in before you can comment on or make changes to this bug.