| Summary: | [Qt] Make the WebKit2 build system less confusing for non-Qt developers | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andras Becsi <abecsi> | ||||||
| Component: | Tools / Tests | Assignee: | Andras Becsi <abecsi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | benjamin, kbalazs, laszlo.gombos, ossy | ||||||
| Priority: | P2 | Keywords: | Qt, QtTriaged | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | PC | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Andras Becsi
2011-02-25 05:12:33 PST
That is a good idea. Yesterday, I was lost with the WebKit2 sources being in WebKit/qt/QtWebKit.pro. I think having them in the WebKit2 dir would be far less confusing. Created attachment 83798 [details]
proposed patch
What about moving these blocks to the existing WebKit2.pri instead of creating yet another build file (WebKit2API.pri) ? (In reply to comment #3) > What about moving these blocks to the existing WebKit2.pri instead of creating yet another build file (WebKit2API.pri) ? I think in this case it is more explicit that those sources are the API, and makes it easier to find out where to add new API sources to. But if adding a new file is a problem, I can surely move these blocks to WebKit2.pri, but I think that would make them almost as much hidden as they were in QtWebKit.pro. I don't have a strong opinion, WebKit2.pri and WebKit2API.pri are good for me. It is all about not confusing non-Qt guys and WebKit2API.pri speaks for itself so I think it is better. Created attachment 83805 [details]
proposed patch v2
I won't fight with the Apple guys even more! I would like to go with the first approach. After think it over again, adding sources and headers to WebKit2.pri and WebKit2.pro can be confusing for non-Qt developers. But the name of WebKit2API.pri must be obviously for everyone. So that's why I'd like to r+ the first one. Comment on attachment 83805 [details]
proposed patch v2
Removing r?, waiting for Ossy.
I also prefer having a new file like WebKit2API.pri (maybe the name isn't perfect, WebKit2ApiSource.pri?) WebKit2.pri contains build details that should not be messed with. This file will likely get more and more complicated over time. I think it is cleaner to have a separate file to reference the source files. Comment on attachment 83798 [details]
proposed patch
Let's go ahead, r=me.
Comment on attachment 83798 [details] proposed patch Clearing flags on attachment: 83798 Committed r79690: <http://trac.webkit.org/changeset/79690> All reviewed patches have been landed. Closing bug. |