Bug 55213

Summary: [Qt] Make the WebKit2 build system less confusing for non-Qt developers
Product: WebKit Reporter: Andras Becsi <abecsi>
Component: Tools / TestsAssignee: Andras Becsi <abecsi>
Severity: Normal CC: benjamin, kbalazs, laszlo.gombos, ossy
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Description Flags
proposed patch
proposed patch v2 none

Description Andras Becsi 2011-02-25 05:12:33 PST
Move the WebKit2 API sources from WebKit/qt/QtWebKit.pro into WebKit2/WebKit2API.pri and include that in the final project file to make it easier to localize where to add new sources.
Comment 1 Benjamin Poulain 2011-02-25 05:19:18 PST
That is a good idea. Yesterday, I was lost with the WebKit2 sources being in WebKit/qt/QtWebKit.pro. I think having them in the WebKit2 dir would be far less confusing.
Comment 2 Andras Becsi 2011-02-25 06:10:24 PST
Created attachment 83798 [details]
proposed patch
Comment 3 Laszlo Gombos 2011-02-25 06:26:33 PST
What about moving these blocks to the existing WebKit2.pri instead of creating yet another build file (WebKit2API.pri) ?
Comment 4 Andras Becsi 2011-02-25 06:35:37 PST
(In reply to comment #3)
> What about moving these blocks to the existing WebKit2.pri instead of creating yet another build file (WebKit2API.pri) ?

I think in this case it is more explicit that those sources are the API, and makes it easier to find out where to add new API sources to.
But if adding a new file is a problem, I can surely move these blocks to WebKit2.pri, but I think that would make them almost as much hidden as they were in QtWebKit.pro.
Comment 5 Csaba Osztrogonác 2011-02-25 06:43:44 PST
I don't have a strong opinion, WebKit2.pri and WebKit2API.pri are good for me.
Comment 6 Balazs Kelemen 2011-02-25 06:46:49 PST
It is all about not confusing non-Qt guys and WebKit2API.pri speaks for itself
so I think it is better.
Comment 7 Andras Becsi 2011-02-25 07:14:24 PST
Created attachment 83805 [details]
proposed patch v2
Comment 8 Balazs Kelemen 2011-02-25 07:18:39 PST
I won't fight with the Apple guys even more! I would like to go with the first approach.
Comment 9 Csaba Osztrogonác 2011-02-25 07:24:26 PST
After think it over again, adding sources and headers to WebKit2.pri 
and WebKit2.pro can be confusing for non-Qt developers. But the name 
of WebKit2API.pri must be obviously for everyone.

So that's why I'd like to r+ the first one.
Comment 10 Andras Becsi 2011-02-25 07:37:03 PST
Comment on attachment 83805 [details]
proposed patch v2

Removing r?, waiting for Ossy.
Comment 11 Benjamin Poulain 2011-02-25 07:42:05 PST
I also prefer having a new file like WebKit2API.pri (maybe the name isn't perfect, WebKit2ApiSource.pri?)

WebKit2.pri contains build details that should not be messed with. This file will likely get more and more complicated over time.

I think it is cleaner to have a separate file to reference the source files.
Comment 12 Csaba Osztrogonác 2011-02-25 10:00:57 PST
Comment on attachment 83798 [details]
proposed patch

Let's go ahead, r=me.
Comment 13 Csaba Osztrogonác 2011-02-25 10:07:16 PST
Comment on attachment 83798 [details]
proposed patch

Clearing flags on attachment: 83798

Committed r79690: <http://trac.webkit.org/changeset/79690>
Comment 14 Csaba Osztrogonác 2011-02-25 10:07:25 PST
All reviewed patches have been landed.  Closing bug.