Bug 55190

Summary:

Crash when trying to send a sync message on an invalid connection

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, mitz

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

OS X 10.5

Attachments:

Description	Flags
Patch	mitz: review+

Description Anders Carlsson 2011-02-24 15:36:35 PST

Crash when trying to send a sync message on an invalid connection

Comment 1 Anders Carlsson 2011-02-24 15:39:06 PST

Created attachment 83734 [details]
Patch

Comment 2 mitz 2011-02-24 15:40:25 PST

Comment on attachment 83734 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83734&action=review

> Source/WebKit2/ChangeLog:11
> +        Don't try to call a client function is isValid() returns false since the client

s/n is/n if/

Comment 3 Anders Carlsson 2011-02-24 15:40:58 PST

Committed r79634: <http://trac.webkit.org/changeset/79634>

Comment 4 Alexey Proskuryakov 2011-02-24 22:52:18 PST

So, all callers of sendSync() need to test for null return value again? This can't be right.

Comment 5 Anders Carlsson 2011-02-25 09:54:52 PST

(In reply to comment #4)
> So, all callers of sendSync() need to test for null return value again? This can't be right.

You obviously can't call the client since the client is null!