Bug 55159 – Variable-sized allocation (but still capped at 64 bytes)

• Component: New Bugs
• Status: RESOLVED FIXED

[Geoffrey Garen]

Variable-sized allocation (but still capped at 64 bytes)

[Geoffrey Garen]

Created attachment 83683 [details]
Patch

[Darin Adler]

Comment on attachment 83683 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83683&action=review

> Source/JavaScriptCore/runtime/JSCell.h:438
> +        if (!result)
> +            result = allocateSlowCase(bytes);
> +        ASSERT(result);
> +        return result;

I like early return better than this construction.

> Source/JavaScriptCore/runtime/MarkedSpace.h:108
> -        SizeClass m_sizeClass;
> +        SizeClass m_precise[preciseCount];

I don’t think that an adjective like precise makes a good name for a data member.

[Build Bot]

Attachment 83683 [details] did not build on win:
Build output: http://queues.webkit.org/results/7981485

[Geoffrey Garen]

Created attachment 83708 [details]
Patch

[Geoffrey Garen]

Committed r79627: <http://trac.webkit.org/changeset/79627>

[Eric Seidel (no email)]

Worker tests are crashing since around this time:

Thread 8 Crashed:  WebCore: Worker
0   com.apple.JavaScriptCore      	0x00000001002b3907 JSC::MarkedBlock::destroy(JSC::MarkedBlock*) + 39 (MarkedBlock.cpp:44)
1   com.apple.JavaScriptCore      	0x000000010022ce48 JSC::MarkedSpace::freeBlocks(WTF::DoublyLinkedList<JSC::MarkedBlock>&) + 392 (MarkedSpace.cpp:66)
2   com.apple.JavaScriptCore      	0x000000010022d593 JSC::MarkedSpace::shrink() + 163 (MarkedSpace.cpp:103)
3   com.apple.JavaScriptCore      	0x0000000100167ced JSC::Heap::destroy() + 109 (Heap.cpp:84)
4   com.apple.WebCore             	0x00000001013c43fc WebCore::WorkerScriptController::~WorkerScriptController() + 76 (WorkerScriptController.cpp:65)
5   com.apple.WebCore             	0x00000001013c7802 WebCore::WorkerThreadShutdownFinishTask::performTask(WebCore::ScriptExecutionContext*) + 50 (WorkerScriptController.h:48)
6   com.apple.WebCore             	0x00000001013c3841 WebCore::WorkerRunLoop::runInMode(WebCore::WorkerContext*, WebCore::ModePredicate const&) + 385 (WorkerRunLoop.cpp:163)
7   com.apple.WebCore             	0x00000001013c3a1e WebCore::WorkerRunLoop::run(WebCore::WorkerContext*) + 238 (WorkerRunLoop.cpp:133)
8   com.apple.WebCore             	0x00000001013c71c0 WebCore::WorkerThread::workerThread() + 992 (WorkerThread.cpp:143)
9   libSystem.B.dylib             	0x00007fff859e3456 _pthread_start + 331
10  libSystem.B.dylib             	0x00007fff859e3309 thread_start + 13

Either this, or bug 55100 is to blame.

[Geoffrey Garen]

Created attachment 84306 [details]
Patch

[Geoffrey Garen]

Comment on attachment 84306 [details]
Patch

Sam reviewed this.

[Geoffrey Garen]

Committed r80052: <http://trac.webkit.org/changeset/80052>

[WebKit Review Bot]

http://trac.webkit.org/changeset/80052 might have broken Qt Linux Release
The following tests are not passing:
fast/canvas/canvas-strokePath-gradient-shadow.html