Summary: | Assertion failure in FrameLoadDelegate::locationChangeDone when running http/tests/navigation/back-twice-without-commit.html | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Adam Roben (:aroben) <aroben> | ||||||
Component: | Tools / Tests | Assignee: | Adam Roben (:aroben) <aroben> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | Keywords: | LayoutTestFailure, PlatformOnly | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Windows XP | ||||||||
URL: | http://build.webkit.org/results/Windows%20XP%20Debug%20(Tests)/r79553%20(25607)/http/tests/navigation/back-twice-without-commit-crash-log.txt | ||||||||
Attachments: |
|
Description
Adam Roben (:aroben)
2011-02-24 08:02:28 PST
Looks like Mac has no such assertion. Removing the assertion causes the test to pass. But I think we can also make the code handle the case of multiple timers for multiple delegates correctly. Created attachment 83659 [details]
Change FrameLoadDelegate to support any number of concurrent timers
Comment on attachment 83659 [details] Change FrameLoadDelegate to support any number of concurrent timers View in context: https://bugs.webkit.org/attachment.cgi?id=83659&action=review > Tools/DumpRenderTree/win/FrameLoadDelegate.cpp:220 > + COMPtr<FrameLoadDelegate> d = timerMap().take(id); Are timer IDs guaranteed to not be 0 or -1? Comment on attachment 83659 [details] Change FrameLoadDelegate to support any number of concurrent timers View in context: https://bugs.webkit.org/attachment.cgi?id=83659&action=review >> Tools/DumpRenderTree/win/FrameLoadDelegate.cpp:220 >> + COMPtr<FrameLoadDelegate> d = timerMap().take(id); > > Are timer IDs guaranteed to not be 0 or -1? Good question! They are guaranteed not to be 0. But I think -1 is a valid timer ID. I guess we need a slightly different solution. I should note that I tried adding a similar assertion to DRT on Mac, and it fired for this test. So we're not seeing some Mac/Windows behavior difference here. Created attachment 83664 [details]
Change FrameLoadDelegate to support any number of delegates with delayed work to process
Committed r79573: <http://trac.webkit.org/changeset/79573> |