Bug 55143 – Web Inspector: Huge fonts in font preview

• Component: Web Inspector (Deprecated)
• Status: RESOLVED FIXED

[Alexander Pavlov (apavlov)]

1. Go to http://pleasingfungus.com/
2. Open the inspector
3. Open the resource tab
4. Select flixelfont.ttf

The font is HUGE! If the inspector window is resized, the font goes back to an appropriate size.

Upstreaming http://code.google.com/p/chromium/issues/detail?id=46731

[Alexander Pavlov (apavlov)]

Created attachment 83653 [details]
[PATCH] Suggested fix

[Pavel Feldman]

Comment on attachment 83653 [details]
[PATCH] Suggested fix

View in context: https://bugs.webkit.org/attachment.cgi?id=83653&action=review

> Source/WebCore/inspector/front-end/FontView.js:56
> +        var uniqueFontName = "WebInspectorFontPreview" + WebInspector.FontView._nextFontId();

Nit: No need for a method here, just inline it.

> Source/WebCore/inspector/front-end/FontView.js:93
> +        var display = element.style.display;

You should encapsulate font metrics and use dummy element added to body, positioned absolutely, behind the screen.

[Alexander Pavlov (apavlov)]

Created attachment 83663 [details]
[PATCH] Comments addressed

[Pavel Feldman]

Comment on attachment 83663 [details]
[PATCH] Comments addressed

View in context: https://bugs.webkit.org/attachment.cgi?id=83663&action=review

> Source/WebCore/inspector/front-end/FontView.js:129
> +        if (firstRun)

This is magic, r- for this.

[Alexander Pavlov (apavlov)]

Created attachment 83793 [details]
[PATCH] Magic removed

[Alexander Pavlov (apavlov)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
        M       Source/WebCore/ChangeLog
        M       Source/WebCore/inspector/front-end/FontView.js
Committed r79677