Bug 55101

Summary: Chromium Pepper plugins render upside down
Product: WebKit Reporter: Neb Sabovic <neb>
Component: Plug-insAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, jamesr, neb, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch jamesr: review+, jamesr: commit-queue-

Description Neb Sabovic 2011-02-23 16:31:48 PST
Using GL API in Pepper results in images being drawn upside down.
Chromium bug: http://code.google.com/p/chromium/issues/detail?id=73930
Comment 1 Neb Sabovic 2011-02-23 17:08:15 PST
Created attachment 83586 [details]
Patch
Comment 2 James Robinson 2011-02-23 17:21:36 PST
Comment on attachment 83586 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=83586&action=review

R=me, but I'll land by hand to fix the ChangeLog.

> ChangeLog:8
> +        * ../../Source/WebCore/platform/graphics/chromium/PluginLayerChromium.h:

hmm, this part of the patch doesn't seem quite right.  This should be a patch to Source/WebCore/ChangeLog and this shouldn't have ../../.  I'll fix on landing.
Comment 3 James Robinson 2011-02-28 17:00:13 PST
Committed r79946: <http://trac.webkit.org/changeset/79946>
Comment 4 WebKit Review Bot 2011-02-28 18:07:58 PST
http://trac.webkit.org/changeset/79946 might have broken Qt Linux Release
The following tests are not passing:
fast/events/tabindex-focus-blur-all.html
fast/frames/iframe-plugin-load-remove-document-crash.html
fast/frames/sandboxed-iframe-attribute-parsing.html
fast/layers/clip-rects-transformed.html
fast/replaced/object-with-non-empty-classid-triggers-fallback.html
plugins/createScriptableObject-before-start.html
plugins/destroy-on-setwindow.html
plugins/destroy-plugin-from-callback.html
plugins/destroy-stream-twice.html
plugins/document-open.html
plugins/evaluate-js-after-removing-plugin-element.html
plugins/get-file-url.html
plugins/get-url-that-the-resource-load-delegate-will-disallow.html
plugins/get-url-with-javascript-destroying-plugin.html
plugins/geturl-replace-query.html
plugins/geturlnotify-during-document-teardown.html
plugins/instance-available-before-stylesheets-loaded-object.html
plugins/invalid-mime-with-valid-extension-shows-missing-plugin.html
plugins/js-from-destroy.html