Bug 55100

Summary: Make WeakGCMap use new handle infrastructure
Product: WebKit Reporter: Oliver Hunt <oliver>
Component: New BugsAssignee: Oliver Hunt <oliver>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 56383    
Attachments:
Description Flags
Patch
none
Patch ggaren: review+

Oliver Hunt
Reported 2011-02-23 16:28:06 PST
Make WeakGCMap use new handle infrastructure
Attachments
Patch (69.19 KB, patch)
2011-02-23 16:42 PST, Oliver Hunt 		no flags
DetailsFormatted DiffDiff
Patch (54.58 KB, patch)
2011-02-24 12:37 PST, Oliver Hunt 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Oliver Hunt
Comment 1 2011-02-23 16:42:54 PST
Created attachment 83576 [details] Patch
Oliver Hunt
Comment 2 2011-02-23 16:43:31 PST
Comment on attachment 83576 [details] Patch I've realised that i can separate out a few bits of this patch completely
Oliver Hunt
Comment 3 2011-02-24 12:37:03 PST
Created attachment 83702 [details] Patch
Geoffrey Garen
Comment 4 2011-02-24 12:51:00 PST
Comment on attachment 83702 [details] Patch r=me I think you should verify performance using the Droameo and DOM Mandlebrot tests.
Oliver Hunt
Comment 5 2011-02-24 14:00:34 PST
Committed r79616: <http://trac.webkit.org/changeset/79616>
Eric Seidel (no email)
Comment 6 2011-02-25 00:06:06 PST
Worker tests are crashing since around this time: Thread 8 Crashed: WebCore: Worker 0 com.apple.JavaScriptCore 0x00000001002b3907 JSC::MarkedBlock::destroy(JSC::MarkedBlock*) + 39 (MarkedBlock.cpp:44) 1 com.apple.JavaScriptCore 0x000000010022ce48 JSC::MarkedSpace::freeBlocks(WTF::DoublyLinkedList<JSC::MarkedBlock>&) + 392 (MarkedSpace.cpp:66) 2 com.apple.JavaScriptCore 0x000000010022d593 JSC::MarkedSpace::shrink() + 163 (MarkedSpace.cpp:103) 3 com.apple.JavaScriptCore 0x0000000100167ced JSC::Heap::destroy() + 109 (Heap.cpp:84) 4 com.apple.WebCore 0x00000001013c43fc WebCore::WorkerScriptController::~WorkerScriptController() + 76 (WorkerScriptController.cpp:65) 5 com.apple.WebCore 0x00000001013c7802 WebCore::WorkerThreadShutdownFinishTask::performTask(WebCore::ScriptExecutionContext*) + 50 (WorkerScriptController.h:48) 6 com.apple.WebCore 0x00000001013c3841 WebCore::WorkerRunLoop::runInMode(WebCore::WorkerContext*, WebCore::ModePredicate const&) + 385 (WorkerRunLoop.cpp:163) 7 com.apple.WebCore 0x00000001013c3a1e WebCore::WorkerRunLoop::run(WebCore::WorkerContext*) + 238 (WorkerRunLoop.cpp:133) 8 com.apple.WebCore 0x00000001013c71c0 WebCore::WorkerThread::workerThread() + 992 (WorkerThread.cpp:143) 9 libSystem.B.dylib 0x00007fff859e3456 _pthread_start + 331 10 libSystem.B.dylib 0x00007fff859e3309 thread_start + 13 Either this, or bug 55159 is to blame.
Note You need to log in before you can comment on or make changes to this bug.