Bug 55093

Summary: [Chromium] Use WebKitClient for OSRandomSource instead of trying to talk to the file system in the sandbox
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: jamesr, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Adam Barth
Reported 2011-02-23 15:31:59 PST
[Chromium] Use WebKitClient for OSRandomSource instead of trying to talk to the file system in the sandbox
Attachments
Patch (4.94 KB, patch)
2011-02-23 15:34 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (4.92 KB, patch)
2011-02-23 15:37 PST, Adam Barth 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2011-02-23 15:34:06 PST
Created attachment 83563 [details] Patch
WebKit Review Bot
Comment 2 2011-02-23 15:35:46 PST
Attachment 83563 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WebKit/chromium/src/ChromiumOSRandomSource.cpp:32: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebKit/chromium/src/ChromiumOSRandomSource.cpp:34: Alphabetical sorting problem. [build/include_order] [4] Source/WebKit/chromium/src/ChromiumOSRandomSource.cpp:44: One space before end of line comments [whitespace/comments] [5] Total errors found: 3 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Barth
Comment 3 2011-02-23 15:37:53 PST
Created attachment 83565 [details] Patch
James Robinson
Comment 4 2011-02-23 15:39:43 PST
Comment on attachment 83565 [details] Patch R=me. this also needs a WebKit/chromium/DEPS change to use a revision that has the WebKitClient function implemented or the crypto layout tests will go boomie.
WebKit Review Bot
Comment 5 2011-02-23 15:40:17 PST
Attachment 83565 [details] did not pass style-queue: Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/JavaScriptCore/ChangeLog', u'Source..." exit_code: 1 Source/WebKit/chromium/src/ChromiumOSRandomSource.cpp:32: Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] Source/WebKit/chromium/src/ChromiumOSRandomSource.cpp:34: Alphabetical sorting problem. [build/include_order] [4] Total errors found: 2 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.
Adam Barth
Comment 6 2011-02-23 16:18:22 PST
Comment on attachment 83565 [details] Patch Clearing flags on attachment: 83565 Committed r79503: <http://trac.webkit.org/changeset/79503>
Adam Barth
Comment 7 2011-02-23 16:18:26 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.